Don't fail on broker.to_s

This would fail if there's a problem with connecting to a broker

Author: sparrovv

lib/kafka/broker.rb

@@ -19,7 +19,7 @@ def address_match?(host, port)
 
     # @return [String]
     def to_s
-      "#{connection} (node_id=#{@node_id.inspect})"
+      "#{connection_to_s} (node_id=#{@node_id.inspect})"
     end
 
     # @return [nil]
@@ -163,5 +163,9 @@ def send_request(request)
     def connection
       @connection ||= @connection_builder.build_connection(@host, @port)
     end
+
+    def connection_to_s
+      connection.to_s rescue nil
+    end
   end
 end

spec/broker_spec.rb

@@ -132,4 +132,14 @@ def close
       broker.disconnect
     end
   end
+
+  describe "#to_s" do
+    it "doesn't fail when building connection fails" do
+      expect(connection_builder).to receive(:build_connection).and_raise(Kafka::ConnectionError)
+
+      expect do
+        broker.to_s
+      end.not_to raise_error
+    end
+  end
 end