Ignore validate_only field

Author: 0x2c7

lib/kafka/client.rb

@@ -479,12 +479,10 @@ def delete_topic(name, timeout: 30)
     # @param num_partitions [Integer] the number of desired partitions for
     # the topic
     # @param timeout [Integer] a duration of time to wait for the new
-    # @param validate_only [Boolean] whether this request is to validate only
-    # without actually execute it
     # partitions to be added.
     # @return [nil]
-    def create_partitions_for(name, num_partitions: 1, timeout: 30, validate_only: false)
-      @cluster.create_partitions_for(name, num_partitions: num_partitions, timeout: timeout, validate_only: validate_only)
+    def create_partitions_for(name, num_partitions: 1, timeout: 30)
+      @cluster.create_partitions_for(name, num_partitions: num_partitions, timeout: timeout)
     end
 
     # Lists all topics in the cluster.

lib/kafka/cluster.rb

@@ -210,12 +210,10 @@ def delete_topic(name, timeout:)
       @logger.info "Topic `#{name}` was deleted"
     end
 
-    def create_partitions_for(name, num_partitions:, timeout:, validate_only:)
-      assignments = nil
+    def create_partitions_for(name, num_partitions:, timeout:)
       options = {
-        topics: [[name, num_partitions, assignments]],
-        timeout: timeout,
-        validate_only: validate_only
+        topics: [[name, num_partitions, nil]],
+        timeout: timeout
       }
 
       broker = controller_broker

lib/kafka/protocol/create_partitions_request.rb

@@ -2,8 +2,8 @@ module Kafka
   module Protocol
 
     class CreatePartitionsRequest
-      def initialize(topics:, timeout:, validate_only:)
-        @topics, @timeout, @validate_only = topics, timeout, validate_only
+      def initialize(topics:, timeout:)
+        @topics, @timeout = topics, timeout
       end
 
       def api_key
@@ -30,7 +30,9 @@ def encode(encoder)
         end
         # Timeout is in ms.
         encoder.write_int32(@timeout * 1000)
-        encoder.write_boolean(@validate_only)
+        # validate_only. There isn't any use case for this in real life. So
+        # let's ignore it for now
+        encoder.write_boolean(false)
       end
     end
 

spec/functional/topic_management_spec.rb

@@ -32,17 +32,4 @@
     kafka.create_partitions_for(topic, num_partitions: 10)
     expect(kafka.partitions_for(topic)).to eq 10
   end
-
-  example "validate partition creation" do
-    unless kafka.supports_api?(Kafka::Protocol::CREATE_PARTITIONS_API)
-      skip("This Kafka version not support ")
-    end
-    topic = generate_topic_name
-
-    kafka.create_topic(topic, num_partitions: 3)
-    expect(kafka.partitions_for(topic)).to eq 3
-
-    kafka.create_partitions_for(topic, num_partitions: 10, validate_only: true)
-    expect(kafka.partitions_for(topic)).to eq 3
-  end
 end