Skip to content

Commit fc5c69d

Browse files
authored
Merge pull request #875 from abicky/resolve-deprecation-warning
Resolve "Passing the keyword argument as ..." deprecation warning
2 parents 8e00bea + fe2fb3d commit fc5c69d

File tree

3 files changed

+15
-4
lines changed

3 files changed

+15
-4
lines changed

.circleci/config.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ jobs:
77
LOG_LEVEL: DEBUG
88
steps:
99
- checkout
10+
- run: sudo apt-get update && sudo apt-get install -y cmake # For installing snappy
1011
- run: bundle install --path vendor/bundle
1112
- run: bundle exec rspec
1213
- run: bundle exec rubocop
@@ -40,6 +41,7 @@ jobs:
4041
KAFKA_DELETE_TOPIC_ENABLE: true
4142
steps:
4243
- checkout
44+
- run: sudo apt-get update && sudo apt-get install -y cmake # For installing snappy
4345
- run: bundle install --path vendor/bundle
4446
- run: bundle exec rspec --profile --tag functional spec/functional
4547

@@ -72,6 +74,7 @@ jobs:
7274
KAFKA_DELETE_TOPIC_ENABLE: true
7375
steps:
7476
- checkout
77+
- run: sudo apt-get update && sudo apt-get install -y cmake # For installing snappy
7578
- run: bundle install --path vendor/bundle
7679
- run: bundle exec rspec --profile --tag functional spec/functional
7780

@@ -104,6 +107,7 @@ jobs:
104107
KAFKA_DELETE_TOPIC_ENABLE: true
105108
steps:
106109
- checkout
110+
- run: sudo apt-get update && sudo apt-get install -y cmake # For installing snappy
107111
- run: bundle install --path vendor/bundle
108112
- run: bundle exec rspec --profile --tag functional spec/functional
109113

@@ -136,6 +140,7 @@ jobs:
136140
KAFKA_DELETE_TOPIC_ENABLE: true
137141
steps:
138142
- checkout
143+
- run: sudo apt-get update && sudo apt-get install -y cmake # For installing snappy
139144
- run: bundle install --path vendor/bundle
140145
- run: bundle exec rspec --profile --tag functional spec/functional
141146

@@ -168,6 +173,7 @@ jobs:
168173
KAFKA_DELETE_TOPIC_ENABLE: true
169174
steps:
170175
- checkout
176+
- run: sudo apt-get update && sudo apt-get install -y cmake # For installing snappy
171177
- run: bundle install --path vendor/bundle
172178
- run: bundle exec rspec --profile --tag functional spec/functional
173179

@@ -200,6 +206,7 @@ jobs:
200206
KAFKA_DELETE_TOPIC_ENABLE: true
201207
steps:
202208
- checkout
209+
- run: sudo apt-get update && sudo apt-get install -y cmake # For installing snappy
203210
- run: bundle install --path vendor/bundle
204211
- run: bundle exec rspec --profile --tag functional spec/functional
205212

@@ -232,6 +239,7 @@ jobs:
232239
KAFKA_DELETE_TOPIC_ENABLE: true
233240
steps:
234241
- checkout
242+
- run: sudo apt-get update && sudo apt-get install -y cmake # For installing snappy
235243
- run: bundle install --path vendor/bundle
236244
- run: bundle exec rspec --profile --tag functional spec/functional
237245

@@ -264,6 +272,7 @@ jobs:
264272
KAFKA_DELETE_TOPIC_ENABLE: true
265273
steps:
266274
- checkout
275+
- run: sudo apt-get update && sudo apt-get install -y cmake # For installing snappy
267276
- run: bundle install --path vendor/bundle
268277
- run: bundle exec rspec --profile --tag functional spec/functional
269278

@@ -296,6 +305,7 @@ jobs:
296305
KAFKA_DELETE_TOPIC_ENABLE: true
297306
steps:
298307
- checkout
308+
- run: sudo apt-get update && sudo apt-get install -y cmake # For installing snappy
299309
- run: bundle install --path vendor/bundle
300310
- run: bundle exec rspec --profile --tag functional spec/functional
301311

@@ -328,6 +338,7 @@ jobs:
328338
KAFKA_DELETE_TOPIC_ENABLE: true
329339
steps:
330340
- checkout
341+
- run: sudo apt-get update && sudo apt-get install -y cmake # For installing snappy
331342
- run: bundle install --path vendor/bundle
332343
- run: bundle exec rspec --profile --tag functional spec/functional
333344

spec/spec_helper.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ def generate_topic_name
6161
"#{RUN_ID}-topic-#{SecureRandom.uuid}"
6262
end
6363

64-
def create_random_topic(*args)
64+
def create_random_topic(**args)
6565
topic = generate_topic_name
66-
create_topic(topic, *args)
66+
create_topic(topic, **args)
6767
topic
6868
end
6969

spec/transaction_manager_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -591,10 +591,10 @@
591591
)
592592
)
593593
allow(group_coordinator).to receive(:txn_offset_commit).and_return(
594-
txn_offset_commit_response(
594+
txn_offset_commit_response({
595595
'hello' => [1],
596596
'world' => [2]
597-
)
597+
})
598598
)
599599
end
600600

0 commit comments

Comments
 (0)