raking the standard

Author: cryptomail

lib/zendesk_api/middleware/request/retry.rb

@@ -41,7 +41,7 @@ def call(env)
           if exception_happened
             original_env[:call_attempt] += 1
             seconds_left = DEFAULT_RETRY_AFTER.to_i
-            @logger.warn "An exception happened, waiting #{seconds_left} seconds... #{exception}" if @logger
+            @logger&.warn "An exception happened, waiting #{seconds_left} seconds... #{exception}"
             instrument_retry(original_env, "exception", seconds_left)
             sleep_with_logging(seconds_left)
             return @app.call(original_env)
@@ -51,7 +51,7 @@ def call(env)
           while response && @error_codes.include?(response.env[:status])
             original_env[:call_attempt] += 1
             seconds_left = (response.env[:response_headers][:retry_after] || DEFAULT_RETRY_AFTER).to_i
-            @logger.warn "You may have been rate limited. Retrying in #{seconds_left} seconds..." if @logger
+            @logger&.warn "You may have been rate limited. Retrying in #{seconds_left} seconds..."
             instrument_retry(original_env, (response.env[:status] == 429) ? "rate_limited" : "server_error", seconds_left)
             sleep_with_logging(seconds_left)
             response = @app.call(original_env)
@@ -80,9 +80,9 @@ def sleep_with_logging(seconds_left)
           seconds_left.times do |i|
             sleep 1 if seconds_left > 0
             time_left = seconds_left - i
-            @logger.warn "#{time_left}..." if time_left > 0 && time_left % 5 == 0 && @logger
+            @logger&.warn "#{time_left}..." if time_left > 0 && time_left % 5 == 0
           end
-          @logger.warn "" if seconds_left > 0 && @logger
+          @logger&.warn "" if seconds_left > 0
         end
       end
     end