Skip to content

Commit 55eefa6

Browse files
authored
feat!: removes stale product colors from palette (#1794)
1 parent 581ccff commit 55eefa6

File tree

10 files changed

+8
-33
lines changed

10 files changed

+8
-33
lines changed

docs/migration.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ consider additional positioning prop support on a case-by-case basis.
5858
- Removed `Sidebar` and `Subnav`: UI no longer recommended by Garden
5959
- Removed `PRODUCT` type export. Use `IHeaderItemProps['product']` instead.
6060
- Removed `hasFooter` prop for `Body` (no replacement needed)
61+
- Removed `message` and `connect` values from `product` prop in `Header.Item` and `Nav.Item`
62+
Typings have been updated accordingly
6163
- The following React component types have changed:
6264
- Removed `IBodyProps` type export.
6365
- `Header.ItemIcon`: `HTMLAttributes<HTMLElement>` -> `SVGAttributes<SVGElement>`
@@ -192,6 +194,7 @@ consider additional positioning prop support on a case-by-case basis.
192194
- The `focusVisibleRef` prop (and the resulting scoping `<div>`) has been
193195
removed from `<ThemeProvider>`. Current browser support obviates the need for a
194196
`:focus-visible` polyfill.
197+
- Removed `message` and `connect` values from `PALETTE.product`
195198
- Utility function `getColor` has been refactored with a signature that supports
196199
v9 light/dark modes. Replace usage with `getColorV8` until custom components can
197200
be upgraded to utilize the new `getColor` function.

packages/chrome/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,17 @@ npm install react react-dom styled-components @zendeskgarden/react-theming
1616
```jsx
1717
import { ThemeProvider } from '@zendeskgarden/react-theming';
1818
import { Chrome, Nav, Body, Header, Content, Main } from '@zendeskgarden/react-chrome';
19-
import ConnectIcon from '@zendeskgarden/icons/src/26/relationshape-connect.svg';
19+
import SupportIcon from '@zendeskgarden/icons/src/26/relationshape-support.svg';
2020
import BrandmarkIcon from '@zendeskgarden/svg-icons/src/26/zendesk.svg';
2121

2222
<ThemeProvider>
2323
<Chrome>
2424
<Nav isExpanded>
25-
<Nav.Item hasLogo product="connect" title="Zendesk Connect">
25+
<Nav.Item hasLogo product="support" title="Zendesk Support">
2626
<Nav.ItemIcon>
27-
<ConnectIcon />
27+
<SupportIcon />
2828
</Nav.ItemIcon>
29-
<NavItemText>Zendesk Connect</NavItemText>
29+
<NavItemText>Zendesk Support</NavItemText>
3030
</Nav.Item>
3131
<Nav.List>
3232
<Nav.Item isCurrent>

packages/chrome/demo/stories/ChromeStory.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@
88
import React, { MouseEventHandler, ReactElement, useState } from 'react';
99
import { Story } from '@storybook/react';
1010
import ChatIcon from '@zendeskgarden/svg-icons/src/26/relationshape-chat.svg';
11-
import ConnectIcon from '@zendeskgarden/svg-icons/src/26/relationshape-connect.svg';
1211
import ExploreIcon from '@zendeskgarden/svg-icons/src/26/relationshape-explore.svg';
1312
import GuideIcon from '@zendeskgarden/svg-icons/src/26/relationshape-guide.svg';
14-
import MessageIcon from '@zendeskgarden/svg-icons/src/26/relationshape-message.svg';
1513
import SupportIcon from '@zendeskgarden/svg-icons/src/26/relationshape-support.svg';
1614
import TalkIcon from '@zendeskgarden/svg-icons/src/26/relationshape-talk.svg';
1715
import ProductIcon from '@zendeskgarden/svg-icons/src/26/garden.svg';
@@ -64,10 +62,8 @@ const NAV_ICONS = [
6462

6563
const PRODUCT_ICONS: Record<Product, ReactElement<SVGElement>> = {
6664
chat: <ChatIcon />,
67-
connect: <ConnectIcon />,
6865
explore: <ExploreIcon />,
6966
guide: <GuideIcon />,
70-
message: <MessageIcon />,
7167
support: <SupportIcon />,
7268
talk: <TalkIcon />
7369
};

packages/chrome/src/elements/header/HeaderItem.spec.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,8 @@ describe('HeaderItem', () => {
4646
describe('Products', () => {
4747
const VALID_COLOR_MAP: Record<Product, string> = {
4848
chat: PALETTE.product.chat,
49-
connect: PALETTE.product.connect,
5049
explore: PALETTE.product.explore,
5150
guide: PALETTE.product.guide,
52-
message: PALETTE.product.message,
5351
support: PALETTE.product.support,
5452
talk: PALETTE.product.talk
5553
};

packages/chrome/src/elements/nav/NavItem.spec.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,10 +177,8 @@ describe('NavItem', () => {
177177
describe('Products', () => {
178178
const VALID_COLOR_MAP: Record<Product, string> = {
179179
chat: PALETTE.product.chat,
180-
connect: PALETTE.product.connect,
181180
explore: PALETTE.product.explore,
182181
guide: PALETTE.product.guide,
183-
message: PALETTE.product.message,
184182
support: PALETTE.product.support,
185183
talk: PALETTE.product.talk
186184
};

packages/chrome/src/styled/header/StyledLogoHeaderItem.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,10 @@ const retrieveProductColor = (props: IStyledLogoHeaderItemProps) => {
2828
switch (props.product) {
2929
case 'chat':
3030
return PALETTE.product.chat;
31-
case 'connect':
32-
return PALETTE.product.connect;
3331
case 'explore':
3432
return PALETTE.product.explore;
3533
case 'guide':
3634
return PALETTE.product.guide;
37-
case 'message':
38-
return PALETTE.product.message;
3935
case 'support':
4036
return PALETTE.product.support;
4137
case 'talk':

packages/chrome/src/styled/nav/StyledLogoNavItem.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,10 @@ const retrieveProductColor = (product?: Product) => {
1616
switch (product) {
1717
case 'chat':
1818
return PALETTE.product.chat;
19-
case 'connect':
20-
return PALETTE.product.connect;
2119
case 'explore':
2220
return PALETTE.product.explore;
2321
case 'guide':
2422
return PALETTE.product.guide;
25-
case 'message':
26-
return PALETTE.product.message;
2723
case 'support':
2824
return PALETTE.product.support;
2925
case 'talk':

packages/chrome/src/types/index.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,7 @@ import { AnchorHTMLAttributes, ButtonHTMLAttributes, HTMLAttributes } from 'reac
99

1010
export const PLACEMENT = ['end', 'start'] as const;
1111

12-
export const PRODUCTS = [
13-
'chat',
14-
'connect',
15-
'explore',
16-
'guide',
17-
'message',
18-
'support',
19-
'talk'
20-
] as const;
12+
export const PRODUCTS = ['chat', 'explore', 'guide', 'support', 'talk'] as const;
2113

2214
export type Product = (typeof PRODUCTS)[number];
2315

packages/theming/src/elements/palette/__snapshots__/index.spec.ts.snap

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,11 +173,9 @@ exports[`PALETTE matches snapshot 1`] = `
173173
},
174174
"product": {
175175
"chat": "#f79a3e",
176-
"connect": "#ff6224",
177176
"explore": "#30aabc",
178177
"gather": "#f6c8be",
179178
"guide": "#eb4962",
180-
"message": "#37b8af",
181179
"sell": "#c38f00",
182180
"support": "#00a656",
183181
"talk": "#efc93d",

packages/theming/src/elements/palette/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,9 @@ const PALETTE = {
1010
white: '#fff',
1111
product: {
1212
support: '#00a656',
13-
message: '#37b8af',
1413
explore: '#30aabc',
1514
gather: '#f6c8be',
1615
guide: '#eb4962',
17-
connect: '#ff6224',
1816
chat: '#f79a3e',
1917
talk: '#efc93d',
2018
sell: '#c38f00'

0 commit comments

Comments
 (0)