Skip to content

Commit 6cdbddc

Browse files
authored
fix(forms): prevent validationLabel warning on Message when validation is undefined (#1547)
1 parent 6da7e4c commit 6cdbddc

File tree

3 files changed

+16
-10
lines changed

3 files changed

+16
-10
lines changed

packages/forms/.size-snapshot.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
{
22
"index.cjs.js": {
3-
"bundled": 133980,
4-
"minified": 95963,
5-
"gzipped": 16785
3+
"bundled": 134006,
4+
"minified": 95974,
5+
"gzipped": 16787
66
},
77
"index.esm.js": {
8-
"bundled": 125526,
9-
"minified": 87781,
10-
"gzipped": 16387,
8+
"bundled": 125552,
9+
"minified": 87792,
10+
"gzipped": 16389,
1111
"treeshaked": {
1212
"rollup": {
13-
"code": 70854,
13+
"code": 70865,
1414
"import_statements": 790
1515
},
1616
"webpack": {
17-
"code": 76199
17+
"code": 76210
1818
}
1919
}
2020
}

packages/forms/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"react-merge-refs": "^1.1.0"
3131
},
3232
"peerDependencies": {
33-
"@zendeskgarden/react-theming": "^8.1.0",
33+
"@zendeskgarden/react-theming": "^8.65.0",
3434
"react": ">=16.8.0",
3535
"react-dom": ">=16.8.0",
3636
"styled-components": "^4.2.0 || ^5.0.0"

packages/forms/src/elements/common/Message.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,13 @@ export const Message = React.forwardRef<HTMLDivElement, IMessageProps>(
5858
combinedProps = getMessageProps(combinedProps);
5959
}
6060

61-
const ariaLabel = useText(Message, combinedProps, 'validationLabel', validation as string);
61+
const ariaLabel = useText(
62+
Message,
63+
combinedProps,
64+
'validationLabel',
65+
validation as string,
66+
validation !== undefined
67+
);
6268

6369
return (
6470
<MessageComponent ref={ref} {...combinedProps}>

0 commit comments

Comments
 (0)