Skip to content

Commit 7bf7272

Browse files
authored
fix(loaders): optimize performance of skeleton loader (#1610)
1 parent eb9208c commit 7bf7272

File tree

3 files changed

+16
-15
lines changed

3 files changed

+16
-15
lines changed

packages/loaders/.size-snapshot.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
{
22
"index.cjs.js": {
3-
"bundled": 20732,
4-
"minified": 16106,
5-
"gzipped": 4232
3+
"bundled": 20801,
4+
"minified": 16175,
5+
"gzipped": 4233
66
},
77
"index.esm.js": {
8-
"bundled": 19197,
9-
"minified": 14618,
10-
"gzipped": 4134,
8+
"bundled": 19266,
9+
"minified": 14687,
10+
"gzipped": 4132,
1111
"treeshaked": {
1212
"rollup": {
13-
"code": 11907,
13+
"code": 11976,
1414
"import_statements": 432
1515
},
1616
"webpack": {
17-
"code": 12875
17+
"code": 12944
1818
}
1919
}
2020
}

packages/loaders/src/elements/Skeleton.spec.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ describe('Skeleton', () => {
5151
it('applies RTL styling correctly', () => {
5252
const { container } = renderRtl(<Skeleton />);
5353

54-
expect(container.firstChild).toHaveStyleRule('right', '-1800px', {
55-
modifier: '&::before'
56-
});
5754
expect(container.firstChild).toHaveStyleRule(
5855
'background-image',
5956
'linear-gradient( -45deg, transparent, rgba(255,255,255,0.6), transparent )',

packages/loaders/src/styled/StyledSkeleton.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,20 @@ const fadeInAnimation = keyframes`
2727
`;
2828

2929
const skeletonAnimation = keyframes`
30+
0% {
31+
transform: translateX(-100%);
32+
}
3033
100% {
31-
left: 100%;
34+
transform: translateX(100%);
3235
}
3336
`;
3437

3538
const skeletonRtlAnimation = keyframes`
39+
0% {
40+
transform: translateX(100%);
41+
}
3642
100% {
37-
right: 100%;
43+
transform: translateX(-100%)
3844
}
3945
`;
4046

@@ -64,13 +70,11 @@ interface IStyledSkeletonProps {
6470
const retrieveSkeletonAnimation = ({ theme }: ThemeProps<DefaultTheme>) => {
6571
if (theme.rtl) {
6672
return css`
67-
right: -1800px;
6873
animation: ${skeletonRtlAnimation} 1.5s ease-in-out 300ms infinite;
6974
`;
7075
}
7176

7277
return css`
73-
left: -1800px;
7478
animation: ${skeletonAnimation} 1.5s ease-in-out 300ms infinite;
7579
`;
7680
};

0 commit comments

Comments
 (0)