fix(theming): align success, warning, and danger border color variables with design (#1936)

Author: jzempel

packages/notifications/src/styled/StyledBase.spec.tsx

@@ -29,11 +29,11 @@ describe('StyledBase', () => {
 
   it.each<{ mode: 'light' | 'dark'; type: Type; color: string }>([
     { mode: 'light', type: 'success', color: PALETTE.green[300] },
-    { mode: 'dark', type: 'success', color: PALETTE.green[800] },
+    { mode: 'dark', type: 'success', color: PALETTE.green[900] },
     { mode: 'light', type: 'error', color: PALETTE.red[300] },
-    { mode: 'dark', type: 'error', color: PALETTE.red[800] },
+    { mode: 'dark', type: 'error', color: PALETTE.red[900] },
     { mode: 'light', type: 'warning', color: PALETTE.yellow[300] },
-    { mode: 'dark', type: 'warning', color: PALETTE.yellow[800] },
+    { mode: 'dark', type: 'warning', color: PALETTE.yellow[900] },
     { mode: 'light', type: 'info', color: PALETTE.grey[300] },
     { mode: 'dark', type: 'info', color: PALETTE.grey[800] }
   ])('renders $mode mode $type border color', ({ mode, type, color }) => {

packages/theming/src/elements/theme/__snapshots__/index.spec.ts.snap

@@ -50,16 +50,16 @@ exports[`DEFAULT_THEME matches snapshot 1`] = `
           "warningEmphasis": "warningHue.600",
         },
         "border": {
-          "danger": "dangerHue.800",
+          "danger": "dangerHue.900",
           "dangerEmphasis": "dangerHue.600",
           "default": "neutralHue.800",
           "disabled": "neutralHue.800",
           "emphasis": "neutralHue.600",
           "primaryEmphasis": "primaryHue.600",
           "subtle": "neutralHue.900",
-          "success": "successHue.800",
+          "success": "successHue.900",
           "successEmphasis": "successHue.600",
-          "warning": "warningHue.800",
+          "warning": "warningHue.900",
           "warningEmphasis": "warningHue.600",
         },
         "foreground": {

packages/theming/src/elements/theme/index.ts

@@ -66,9 +66,9 @@ const colors = {
         default: 'neutralHue.800',
         emphasis: 'neutralHue.600',
         subtle: 'neutralHue.900',
-        success: 'successHue.800',
-        warning: 'warningHue.800',
-        danger: 'dangerHue.800',
+        success: 'successHue.900',
+        warning: 'warningHue.900',
+        danger: 'dangerHue.900',
         primaryEmphasis: 'primaryHue.600',
         successEmphasis: 'successHue.600',
         warningEmphasis: 'warningHue.600',