Skip to content

Commit 9e5618b

Browse files
fix(avatars): explicitly set box sizing for status indicator icon container (#1564)
1 parent 96d526f commit 9e5618b

File tree

3 files changed

+15
-11
lines changed

3 files changed

+15
-11
lines changed

packages/avatars/.size-snapshot.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
{
22
"index.cjs.js": {
3-
"bundled": 21646,
4-
"minified": 15766,
5-
"gzipped": 4079
3+
"bundled": 21669,
4+
"minified": 15789,
5+
"gzipped": 4081
66
},
77
"index.esm.js": {
8-
"bundled": 19928,
9-
"minified": 14251,
10-
"gzipped": 3856,
8+
"bundled": 19951,
9+
"minified": 14274,
10+
"gzipped": 3859,
1111
"treeshaked": {
1212
"rollup": {
13-
"code": 11632,
13+
"code": 11655,
1414
"import_statements": 341
1515
},
1616
"webpack": {
17-
"code": 12478
17+
"code": 12501
1818
}
1919
}
2020
}

packages/avatars/demo/~patterns/stories/StatusMenuStory.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import { Story } from '@storybook/react';
1010
import { Col, Grid, Row } from '@zendeskgarden/react-grid';
1111
import { Dropdown, Trigger, Menu, Item } from '@zendeskgarden/react-dropdowns';
1212
import { Avatar, IStatusIndicatorProps, StatusIndicator } from '@zendeskgarden/react-avatars';
13+
import { IconButton } from '@zendeskgarden/react-buttons';
1314

1415
export const StatusMenuStory: Story = ({ isCompact }) => {
1516
const [selectedType, setSelectedType] = useState<IStatusIndicatorProps['type']>();
@@ -20,9 +21,11 @@ export const StatusMenuStory: Story = ({ isCompact }) => {
2021
<Col textAlign="center" alignSelf="center">
2122
<Dropdown selectedItem={selectedType} onSelect={value => setSelectedType(value)}>
2223
<Trigger>
23-
<Avatar status={selectedType} size={isCompact ? 'small' : 'medium'}>
24-
<img alt="Example User" src="images/avatars/chrome.png" />
25-
</Avatar>
24+
<IconButton>
25+
<Avatar status={selectedType} size={isCompact ? 'small' : 'medium'}>
26+
<img alt="Example User" src="images/avatars/chrome.png" />
27+
</Avatar>
28+
</IconButton>
2629
</Trigger>
2730
<Menu isCompact={isCompact}>
2831
<Item value="offline">

packages/avatars/src/styled/StyledStandaloneStatusIndicator.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ export const StyledStandaloneStatusIndicator = styled(StyledStatusIndicatorBase)
1818
'data-garden-version': PACKAGE_VERSION
1919
})<IStyledStatusIndicatorProps>`
2020
position: relative;
21+
box-sizing: content-box;
2122
margin-top: ${props =>
2223
`calc((${props.theme.lineHeights.md} - ${getStatusSize(props, '0')}) / 2)`};
2324

0 commit comments

Comments
 (0)