use ! empty($this->prop) notation

- simplifies conditionals

Author: weierophinney

module/Application/view/error/404.phtml

@@ -1,7 +1,7 @@
 <h1>A 404 error occurred</h1>
 <h2><?= $this->message ?></h2>
 
-<?php if (!empty($this->reason)) : ?>
+<?php if (! empty($this->reason)) : ?>
     <?php
     switch ($this->reason) {
         case \Zend\Mvc\Application::ERROR_CONTROLLER_CANNOT_DISPATCH:
@@ -27,24 +27,21 @@
 <p><?= $reasonMessage ?></p>
 <?php endif ?>
 
-<?php if (isset($this->controller) && $this->controller) : ?>
+<?php if (! empty($this->controller)) : ?>
 <dl>
     <dt>Controller:</dt>
     <dd>
         <?= $this->escapeHtml($this->controller) ?>
         <?php
-        if (isset($this->controller_class)
-            && $this->controller_class
-            && $this->controller_class != $this->controller
-        ) {
-            echo '(' . sprintf('resolves to %s', $this->escapeHtml($this->controller_class)) . ')';
+        if (! empty($this->controller_class) && $this->controller_class != $this->controller) {
+            printf('(resolves to %s)', $this->escapeHtml($this->controller_class));
         }
         ?>
     </dd>
 </dl>
 <?php endif ?>
 
-<?php if (isset($this->display_exceptions) && $this->display_exceptions) : ?>
+<?php if (! empty($this->display_exceptions)) : ?>
     <?php if (isset($this->exception) && ($this->exception instanceof \Exception || $this->exception instanceof \Error)) : ?>
 <hr/>
 
@@ -92,7 +89,7 @@
                 <?php
                 $ex = $ex->getPrevious();
                 if (++$icount >= 50) {
-                    echo '<li>There may be more exceptions, but we have no enough memory to proccess it.</li>';
+                    echo '<li>There may be more exceptions, but we do not have enough memory to process it.</li>';
                     break;
                 }
                 ?>

module/Application/view/error/index.phtml

@@ -1,7 +1,7 @@
 <h1>An error occurred</h1>
 <h2><?= $this->message ?></h2>
 
-<?php if (isset($this->display_exceptions) && $this->display_exceptions) : ?>
+<?php if (! empty($this->display_exceptions)) : ?>
     <?php if (isset($this->exception) && ($this->exception instanceof \Exception || $this->exception instanceof \Error)) : ?>
 <hr/>
 
@@ -27,8 +27,8 @@
 
 <h2>Previous exceptions:</h2>
 <ul class="list-unstyled">
-                <?php $icount = 0 ?>
-                <?php while ($ex) : ?>
+            <?php $icount = 0 ?>
+            <?php while ($ex) : ?>
     <li>
         <h3><?= get_class($ex) ?></h3>
         <dl>
@@ -46,14 +46,14 @@
             </dd>
         </dl>
     </li>
-                    <?php
-                    $ex = $ex->getPrevious();
-                    if (++$icount >= 50) {
-                        echo '<li>There may be more exceptions, but we have no enough memory to proccess it.</li>';
-                        break;
-                    }
-                    ?>
-                <?php endwhile ?>
+                <?php
+                $ex = $ex->getPrevious();
+                if (++$icount >= 50) {
+                    echo '<li>There may be more exceptions, but we do not have enough memory to process it.</li>';
+                    break;
+                }
+                ?>
+            <?php endwhile ?>
 </ul>
         <?php endif ?>
     <?php else : ?>