Merge branch 'feature/39' into develop

Xerkus · Xerkus · commit 832fe5801db0 · 2019-05-07T05:53:53.000+10:00
Close #39
diff --git a/src/Adapter/Digest.php b/src/Adapter/Digest.php
@@ -162,7 +162,6 @@ public function authenticate()
         }
 
         $id       = "$this->identity:$this->realm";
-        $idLength = strlen($id);
 
         $result = [
             'code'  => AuthenticationResult::FAILURE,
@@ -178,7 +177,7 @@ public function authenticate()
             if (empty($line)) {
                 break;
             }
-            if (substr($line, 0, $idLength) === $id) {
+            if (0 === strpos($line, $id)) {
                 if (CryptUtils::compareStrings(
                     substr($line, -32),
                     md5("$this->identity:$this->realm:$this->credential")

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,6 @@ public function authenticate()`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`$id = "$this->identity:$this->realm";`
`165`		`- $idLength = strlen($id);`
`166`	`165`
`167`	`166`	`$result = [`
`168`	`167`	`'code' => AuthenticationResult::FAILURE,`
`@@ -178,7 +177,7 @@ public function authenticate()`
`178`	`177`	`if (empty($line)) {`
`179`	`178`	`break;`
`180`	`179`	`}`
`181`		`- if (substr($line, 0, $idLength) === $id) {`
	`180`	`+ if (0 === strpos($line, $id)) {`
`182`	`181`	`if (CryptUtils::compareStrings(`
`183`	`182`	`substr($line, -32),`
`184`	`183`	`md5("$this->identity:$this->realm:$this->credential")`