Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Commit 9c49a5e

Browse files
committed
Incorporate docs review feedback
1 parent 8a5064d commit 9c49a5e

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

docs/book/adapter/dbtable/credential-treatment.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,17 @@ More details are available in the next section.
1515

1616
Passing passwords to database in plaintext for insert or verification is
1717
generally not recommended.
18-
Sql statements can and usually are logged by the database, passwords in them
18+
Sql statements can and usually are logged by the database, and passwords in them
1919
become visible to anyone with access to the logs or monitoring tools that
2020
consume those logs.
2121

22-
Safer way is to hash passwords and verify them against stored hash on the
23-
application side. This way password never needs to leave application and only
24-
hashed value exchanged with database.
22+
The safer approach is to hash passwords, and to verify them against a stored
23+
hash in your application code. This way the password never leaves the
24+
application, and only the hashed value is exchanged with the database.
2525

26-
As such, this adapter is not recommended for new applications and existing
27-
applications should consider migrating to using PHP provided password handling
28-
functions `password_hash()` and `password_verify()`. See
26+
As such, this adapter is not recommended for new applications, and existing
27+
applications should consider migrating to using PHP-provided password handling
28+
functions such as `password_hash()` and `password_verify()`. See
2929
[CallbackCheckAdapter](callback-check.md) for more info.
3030

3131
## Configuration Options
@@ -261,8 +261,8 @@ $sqlAlter = "ALTER TABLE [users] "
261261
```
262262

263263
Salts should be created *for each user* using a cryptographically sound pseudo-random number generator (CSPRNG).
264-
PHP 7 provides an implementation via `random_bytes` (and
265-
[`random_compat` for older supported versions of PHP](https://github.com/paragonie/random_compat)):
264+
PHP 7 provides an implementation via `random_bytes()` (and
265+
the [random_compat package provides them for older, supported versions of PHP](https://github.com/paragonie/random_compat)):
266266

267267
```php
268268
$salt = random_bytes(32);

0 commit comments

Comments
 (0)