Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Commit 9377faa

Browse files
committed
[#50] Reinstated tests and made proper docblocks
- Reinstated the two tests that were removed. - Updated property docblocks to be full length vs single-line, per our CS.
1 parent d4199e7 commit 9377faa

File tree

8 files changed

+47
-11
lines changed

8 files changed

+47
-11
lines changed

test/MessageTraitTest.php

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@
1515

1616
class MessageTraitTest extends TestCase
1717
{
18-
/** @var MessageInterface */
18+
/**
19+
* @var MessageInterface
20+
*/
1921
protected $message;
2022

2123
public function setUp()
@@ -35,6 +37,13 @@ public function testProtocolMutatorReturnsCloneWithChanges()
3537
$this->assertEquals('1.0', $message->getProtocolVersion());
3638
}
3739

40+
public function testUsesStreamProvidedInConstructorAsBody()
41+
{
42+
$stream = $this->getMock('Psr\Http\Message\StreamInterface');
43+
$message = new Request(null, null, $stream);
44+
$this->assertSame($stream, $message->getBody());
45+
}
46+
3847
public function testBodyMutatorReturnsCloneWithChanges()
3948
{
4049
$stream = $this->getMock('Psr\Http\Message\StreamInterface');
@@ -183,6 +192,13 @@ public function testWithoutHeaderDoesNothingIfHeaderDoesNotExist()
183192
$this->assertFalse($message->hasHeader('X-Foo'));
184193
}
185194

195+
public function testHeadersInitialization()
196+
{
197+
$headers = ['X-Foo' => ['bar']];
198+
$message = new Request(null, null, 'php://temp', $headers);
199+
$this->assertSame($headers, $message->getHeaders());
200+
}
201+
186202
public function testGetHeaderReturnsAnEmptyArrayWhenHeaderDoesNotExist()
187203
{
188204
$this->assertSame([], $this->message->getHeader('X-Foo-Bar'));

test/PhpInputStreamTest.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,14 @@
1414

1515
class PhpInputStreamTest extends TestCase
1616
{
17-
/** @var string */
17+
/**
18+
* @var string
19+
*/
1820
protected $file;
1921

20-
/** @var PhpInputStream */
22+
/**
23+
* @var PhpInputStream
24+
*/
2125
protected $stream;
2226

2327
public function setUp()

test/RequestTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616

1717
class RequestTest extends TestCase
1818
{
19-
/** @var Request */
19+
/**
20+
* @var Request
21+
*/
2022
protected $request;
2123

2224
public function setUp()

test/Response/SapiEmitterTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717

1818
class SapiEmitterTest extends TestCase
1919
{
20-
/** @var SapiEmitter */
20+
/**
21+
* @var SapiEmitter
22+
*/
2123
protected $emitter;
2224

2325
public function setUp()

test/ResponseTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@
1515

1616
class ResponseTest extends TestCase
1717
{
18-
/** @var Response */
18+
/**
19+
* @var Response
20+
*/
1921
protected $response;
2022

2123
public function setUp()

test/ServerRequestTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717

1818
class ServerRequestTest extends TestCase
1919
{
20-
/** @var ServerRequest */
20+
/**
21+
* @var ServerRequest
22+
*/
2123
protected $request;
2224

2325
public function setUp()

test/ServerTest.php

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,19 @@
1717

1818
class ServerTest extends TestCase
1919
{
20-
/** @var Callable */
20+
/**
21+
* @var Callable
22+
*/
2123
protected $callback;
2224

23-
/** @var ServerRequestInterface|\PHPUnit_Framework_MockObject_MockObject */
25+
/**
26+
* @var ServerRequestInterface|\PHPUnit_Framework_MockObject_MockObject
27+
*/
2428
protected $request;
2529

26-
/** @var ResponseInterface|\PHPUnit_Framework_MockObject_MockObject */
30+
/**
31+
* @var ResponseInterface|\PHPUnit_Framework_MockObject_MockObject
32+
*/
2733
protected $response;
2834

2935
public function setUp()

test/StreamTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ class StreamTest extends TestCase
1717
{
1818
public $tmpnam;
1919

20-
/** @var Stream */
20+
/**
21+
* @var Stream
22+
*/
2123
protected $stream;
2224

2325
public function setUp()

0 commit comments

Comments
 (0)