Merge branch 'hotfix/290'

Close #290

Author: weierophinney

CHANGELOG.md

@@ -26,7 +26,10 @@ All notable changes to this project will be documented in this file, in reverse
 
 ### Fixed
 
-- Nothing.
+- [#290](https://github.com/zendframework/zend-diactoros/pull/290) fixes
+  `Stream::getSize()` such that it checks that the result of `fstat` was
+  succesful before attempting to return its `size` member; in the case of an
+  error, it now returns `null`.
 
 ## 1.7.0 - 2018-01-04
 

src/Stream.php

@@ -103,7 +103,11 @@ public function getSize()
         }
 
         $stats = fstat($this->resource);
-        return $stats['size'];
+        if ($stats !== false) {
+            return $stats['size'];
+        }
+
+        return null;
     }
 
     /**

test/StreamTest.php

@@ -632,4 +632,14 @@ public function testCanReadContentFromNotSeekableResource()
 
         $this->assertSame('FOO BAR', $stream->__toString());
     }
+
+    /**
+     * @group 42
+     */
+    public function testSizeReportsNullForPhpInputStreams()
+    {
+        $resource = fopen('php://input', 'r');
+        $stream = new Stream($resource);
+        $this->assertNull($stream->getSize());
+    }
 }