added tests for GuzzleHttpService

Author: kbond

composer.json

@@ -21,7 +21,8 @@
         "zendframework/zend-loader"  : "2.*",
         "sensiolabs/security-checker": "1.3.*@dev",
         "symfony/yaml": "v2.3.11",
-        "guzzle/http"                : "3.*"
+        "guzzle/http"                : "3.*",
+        "guzzle/plugin-mock"         : "3.*"
     },
     "suggest" : {
         "ext-bcmath" : "Required by Check\\CpuPerformance",

src/ZendDiagnostics/Check/GuzzleHttpService.php

@@ -52,7 +52,7 @@ public function check()
             return new Failure("Status code {$this->statusCode} does not match response from {$this->url}");
         }
 
-        if ($this->content && !strpos($response->getBody(true), $this->content)) {
+        if ($this->content && (false === strpos($response->getBody(true), $this->content))) {
             return new Failure("Content {$this->content} not found in response from {$this->url}");
         }
 

tests/ZendDiagnosticsTest/GuzzleHttpServiceTest.php

@@ -0,0 +1,54 @@
+<?php
+
+namespace ZendDiagnosticsTest;
+
+use Guzzle\Http\Client;
+use Guzzle\Http\Message\Response;
+use Guzzle\Plugin\Mock\MockPlugin;
+use ZendDiagnostics\Check\GuzzleHttpService;
+
+class GuzzleHttpServiceTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @dataProvider checkProvider
+     */
+    public function testCheck($content, $actualContent, $actualStatusCode, $resultClass)
+    {
+        $check = new GuzzleHttpService(
+            'http://www.example.com/foobar',
+            array(),
+            array(),
+            200,
+            $content,
+            $this->getMockClient($actualStatusCode, $actualContent)
+        );
+        $result = $check->check();
+
+        $this->assertInstanceOf($resultClass, $result);
+    }
+
+    public function checkProvider()
+    {
+        return array(
+            array(null, null, 200, 'ZendDiagnostics\Result\SuccessInterface'),
+            array(null, null, 404, 'ZendDiagnostics\Result\FailureInterface'),
+            array('foo', 'foobar', 200, 'ZendDiagnostics\Result\SuccessInterface'),
+            array('baz', 'foobar', 200, 'ZendDiagnostics\Result\FailureInterface')
+        );
+    }
+
+    private function getMockClient($statusCode = 200, $content = null)
+    {
+        $plugin = new MockPlugin();
+        $plugin->addResponse(new Response($statusCode, null, $content));
+
+        $client = new Client(null, array(
+            'request.options' => array(
+                'exceptions' => false
+            )
+        ));
+        $client->addSubscriber($plugin);
+
+        return $client;
+    }
+}