refactor: Make anonymous classes into actual test asset classes

Required to allow us to test against PHP 5.6.

Author: weierophinney

test/ListenerProvider/AbstractListenerSubscriberTest.php

@@ -7,31 +7,13 @@
 
 namespace ZendTest\EventManager\ListenerProvider;
 
-use Closure;
-use Zend\EventManager\ListenerProvider\AbstractListenerSubscriber;
-use Zend\EventManager\ListenerProvider\PrioritizedListenerAttachmentInterface;
-
 class AbstractListenerSubscriberTest extends ListenerSubscriberTraitTest
 {
     /**
      * {@inheritDoc}
      */
     public function createProvider(callable $attachmentCallback)
     {
-        return new class($attachmentCallback) extends AbstractListenerSubscriber {
-            /** @var callable */
-            private $attachmentCallback;
-
-            public function __construct(callable $attachmentCallback)
-            {
-                $this->attachmentCallback = $attachmentCallback;
-            }
-
-            public function attach(PrioritizedListenerAttachmentInterface $provider, $priority = 1)
-            {
-                $attachmentCallback = $this->attachmentCallback->bindTo($this, $this);
-                $attachmentCallback($provider, $priority);
-            }
-        };
+        return new TestAsset\ExtendedCallbackSubscriber($attachmentCallback);
     }
 }

test/ListenerProvider/LazyListenerTest.php

@@ -10,7 +10,6 @@
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;
 use Psr\Container\ContainerInterface;
-use stdClass;
 use Zend\EventManager\EventInterface;
 use Zend\EventManager\Exception\InvalidArgumentException;
 use Zend\EventManager\ListenerProvider\LazyListener;
@@ -134,22 +133,7 @@ public function methodsToInvoke()
      */
     public function testInvocationInvokesMethodDefinedInListener($method, $expected)
     {
-        $listener = new class {
-            public function __invoke($e)
-            {
-                $e->value = __FUNCTION__;
-            }
-
-            public function run($e)
-            {
-                $e->value = __FUNCTION__;
-            }
-
-            public function onEvent($e)
-            {
-                $e->value = __FUNCTION__;
-            }
-        };
+        $listener = new TestAsset\MultipleListener();
 
         $this->container
             ->get('listener')

test/ListenerProvider/ListenerSubscriberTraitTest.php

@@ -10,7 +10,6 @@
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;
 use Zend\EventManager\ListenerProvider\ListenerSubscriberInterface;
-use Zend\EventManager\ListenerProvider\ListenerSubscriberTrait;
 use Zend\EventManager\ListenerProvider\PrioritizedListenerAttachmentInterface;
 
 class ListenerSubscriberTraitTest extends TestCase
@@ -20,23 +19,7 @@ class ListenerSubscriberTraitTest extends TestCase
      */
     public function createProvider(callable $attachmentCallback)
     {
-        return new class($attachmentCallback) implements ListenerSubscriberInterface {
-            use ListenerSubscriberTrait;
-
-            /** @var callable */
-            private $attachmentCallback;
-
-            public function __construct(callable $attachmentCallback)
-            {
-                $this->attachmentCallback = $attachmentCallback;
-            }
-
-            public function attach(PrioritizedListenerAttachmentInterface $provider, $priority = 1)
-            {
-                $attachmentCallback = $this->attachmentCallback->bindTo($this, $this);
-                $attachmentCallback($provider, $priority);
-            }
-        };
+        return new TestAsset\CallbackSubscriber($attachmentCallback);
     }
 
     public function testSubscriberAttachesListeners()

test/ListenerProvider/TestAsset/CallbackSubscriber.php

@@ -0,0 +1,31 @@
+<?php
+/**
+ * @see       https://github.com/zendframework/zend-eventmanager for the canonical source repository
+ * @copyright Copyright (c) 2019 Zend Technologies USA Inc. (https://www.zend.com)
+ * @license   https://github.com/zendframework/zend-eventmanager/blob/master/LICENSE.md New BSD License
+ */
+
+namespace ZendTest\EventManager\ListenerProvider\TestAsset;
+
+use Zend\EventManager\ListenerProvider\ListenerSubscriberInterface;
+use Zend\EventManager\ListenerProvider\ListenerSubscriberTrait;
+use Zend\EventManager\ListenerProvider\PrioritizedListenerAttachmentInterface;
+
+class CallbackSubscriber implements ListenerSubscriberInterface
+{
+    use ListenerSubscriberTrait;
+
+    /** @var callable */
+    private $attachmentCallback;
+
+    public function __construct(callable $attachmentCallback)
+    {
+        $this->attachmentCallback = $attachmentCallback;
+    }
+
+    public function attach(PrioritizedListenerAttachmentInterface $provider, $priority = 1)
+    {
+        $attachmentCallback = $this->attachmentCallback->bindTo($this, $this);
+        $attachmentCallback($provider, $priority);
+    }
+}

test/ListenerProvider/TestAsset/ExtendedCallbackSubscriber.php

@@ -0,0 +1,28 @@
+<?php
+/**
+ * @see       https://github.com/zendframework/zend-eventmanager for the canonical source repository
+ * @copyright Copyright (c) 2019 Zend Technologies USA Inc. (https://www.zend.com)
+ * @license   https://github.com/zendframework/zend-eventmanager/blob/master/LICENSE.md New BSD License
+ */
+
+namespace ZendTest\EventManager\ListenerProvider\TestAsset;
+
+use Zend\EventManager\ListenerProvider\AbstractListenerSubscriber;
+use Zend\EventManager\ListenerProvider\PrioritizedListenerAttachmentInterface;
+
+class ExtendedCallbackSubscriber extends AbstractListenerSubscriber
+{
+    /** @var callable */
+    private $attachmentCallback;
+
+    public function __construct(callable $attachmentCallback)
+    {
+        $this->attachmentCallback = $attachmentCallback;
+    }
+
+    public function attach(PrioritizedListenerAttachmentInterface $provider, $priority = 1)
+    {
+        $attachmentCallback = $this->attachmentCallback->bindTo($this, $this);
+        $attachmentCallback($provider, $priority);
+    }
+}

test/ListenerProvider/TestAsset/MultipleListener.php

@@ -0,0 +1,26 @@
+<?php
+/**
+ * @see       https://github.com/zendframework/zend-eventmanager for the canonical source repository
+ * @copyright Copyright (c) 2019 Zend Technologies USA Inc. (https://www.zend.com)
+ * @license   https://github.com/zendframework/zend-eventmanager/blob/master/LICENSE.md New BSD License
+ */
+
+namespace ZendTest\EventManager\ListenerProvider\TestAsset;
+
+class MultipleListener
+{
+    public function __invoke($e)
+    {
+        $e->value = __FUNCTION__;
+    }
+
+    public function run($e)
+    {
+        $e->value = __FUNCTION__;
+    }
+
+    public function onEvent($e)
+    {
+        $e->value = __FUNCTION__;
+    }
+}