Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Commit 0e5a018

Browse files
committed
Refactors ConfigProvider dependencies
- Aliases `RouterInterface` to `ZendRouter` - Marks `ZendRouter` as an invokable
1 parent dba214f commit 0e5a018

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

src/ZendRouter/ConfigProvider.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,12 @@ public function __invoke() : array
2424
public function getDependencies() : array
2525
{
2626
return [
27-
'factories' => [
27+
'aliases' => [
2828
RouterInterface::class => ZendRouter::class,
2929
],
30+
'invokables' => [
31+
ZendRouter::class => ZendRouter::class,
32+
],
3033
];
3134
}
3235
}

test/ZendRouter/ConfigProviderTest.php

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
use PHPUnit\Framework\TestCase;
1313
use Zend\Expressive\Router\RouterInterface;
14+
use Zend\Expressive\Router\ZendRouter;
1415
use Zend\Expressive\Router\ZendRouter\ConfigProvider;
1516

1617
class ConfigProviderTest extends TestCase
@@ -40,8 +41,13 @@ public function testReturnedArrayContainsDependencies(array $config) : void
4041
{
4142
self::assertArrayHasKey('dependencies', $config);
4243
self::assertInternalType('array', $config['dependencies']);
43-
self::assertArrayHasKey('factories', $config['dependencies']);
44-
self::assertInternalType('array', $config['dependencies']['factories']);
45-
self::assertArrayHasKey(RouterInterface::class, $config['dependencies']['factories']);
44+
45+
self::assertArrayHasKey('aliases', $config['dependencies']);
46+
self::assertInternalType('array', $config['dependencies']['aliases']);
47+
self::assertArrayHasKey(RouterInterface::class, $config['dependencies']['aliases']);
48+
49+
self::assertArrayHasKey('invokables', $config['dependencies']);
50+
self::assertInternalType('array', $config['dependencies']['invokables']);
51+
self::assertArrayHasKey(ZendRouter::class, $config['dependencies']['invokables']);
4652
}
4753
}

0 commit comments

Comments
 (0)