Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Commit 00278d4

Browse files
committed
Merge pull request #35 from webimpress/feature/updates
Repository Updates + Coveralls configuration
2 parents 3a38fd5 + fbc0bad commit 00278d4

19 files changed

+404
-216
lines changed

.coveralls.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
coverage_clover: clover.xml
2+
json_path: coveralls-upload.json

.gitattributes

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/test export-ignore
2-
/vendor export-ignore
2+
.coveralls.yml
33
.gitattributes export-ignore
44
.gitignore export-ignore
55
.travis.yml export-ignore
6-
phpunit.xml.dist export-ignore
76
phpcs.xml export-ignore
7+
phpunit.xml.dist export-ignore

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,4 @@
11
vendor/
2+
phpunit.xml
3+
clover.xml
4+
coveralls-upload.json

.travis.yml

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,24 @@ language: php
55
cache:
66
directories:
77
- $HOME/.composer/cache
8+
- $HOME/.local
89
- vendor
910

1011
env:
1112
global:
12-
- COMPOSER_ARGS="--no-interaction --ignore-platform-reqs"
13+
- COMPOSER_ARGS="--no-interaction"
14+
- COVERAGE_DEPS="satooshi/php-coveralls"
15+
- LEGACY_DEPS="phpunit/phpunit"
1316

1417
matrix:
15-
fast_finish: true
1618
include:
1719
- php: 5.6
1820
env:
1921
- DEPS=lowest
2022
- php: 5.6
2123
env:
2224
- DEPS=locked
25+
- TEST_COVERAGE=true
2326
- php: 5.6
2427
env:
2528
- DEPS=latest
@@ -29,7 +32,7 @@ matrix:
2932
- php: 7
3033
env:
3134
- DEPS=locked
32-
- CHECK_CS=true
35+
- CS_CHECK=true
3336
- php: 7
3437
env:
3538
- DEPS=latest
@@ -55,18 +58,25 @@ matrix:
5558
- php: hhvm
5659

5760
before_install:
61+
- if [[ $TEST_COVERAGE != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi
5862
- travis_retry composer self-update
5963

6064
install:
65+
- travis_retry composer install $COMPOSER_ARGS --ignore-platform-reqs
66+
- if [[ $TRAVIS_PHP_VERSION =~ ^5.6 ]]; then travis_retry composer update $COMPOSER_ARGS --with-dependencies $LEGACY_DEPS ; fi
6167
- if [[ $DEPS == 'latest' ]]; then travis_retry composer update $COMPOSER_ARGS ; fi
6268
- if [[ $DEPS == 'lowest' ]]; then travis_retry composer update --prefer-lowest --prefer-stable $COMPOSER_ARGS ; fi
63-
- travis_retry composer install $COMPOSER_ARGS
64-
- composer info
69+
- if [[ $TEST_COVERAGE == 'true' ]]; then travis_retry composer require --dev $COMPOSER_ARGS $COVERAGE_DEPS ; fi
70+
- composer show
6571

6672
script:
67-
- composer test
68-
- if [[ $CHECK_CS == 'true' ]]; then composer cs ; fi
69-
- if [[ $CHECK_CS == 'true' ]]; then composer license-check ; fi
73+
- if [[ $TEST_COVERAGE == 'true' ]]; then composer test-coverage ; else composer test ; fi
74+
- if [[ $CS_CHECK == 'true' ]]; then composer cs-check ; fi
75+
- if [[ $CS_CHECK == 'true' ]]; then composer license-check ; fi
76+
77+
after_script:
78+
- if [[ $TEST_COVERAGE == 'true' ]]; then composer upload-coverage ; fi
7079

7180
notifications:
72-
email: true
81+
irc: "irc.freenode.org#zftalk.dev"
82+
email: false

CONTRIBUTING.md

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,17 @@ To run tests:
4141
- Clone the repository:
4242

4343
```console
44-
$ git clone git@github.com:zendframework/zend-expressive-zendviewrenderer.git
44+
$ git clone git://github.com/zendframework/zend-expressive-zendviewrenderer.git
4545
$ cd zend-expressive-zendviewrenderer
4646
```
4747

4848
- Install dependencies via composer:
4949

5050
```console
51-
$ curl -sS https://getcomposer.org/installer | php --
52-
$ ./composer.phar install
51+
$ composer install
5352
```
5453

55-
If you don't have `curl` installed, you can also download `composer.phar` from https://getcomposer.org/
54+
If you don't have `composer` installed, please download it from https://getcomposer.org/download/
5655

5756
- Run the tests using the "test" command shipped in the `composer.json`:
5857

@@ -75,31 +74,42 @@ section on running tests.
7574
To run CS checks only:
7675

7776
```console
78-
$ composer cs
77+
$ composer cs-check
7978
```
8079

8180
To attempt to automatically fix common CS issues:
8281

83-
8482
```console
8583
$ composer cs-fix
8684
```
8785

8886
If the above fixes any CS issues, please re-run the tests to ensure
8987
they pass, and make sure you add and commit the changes after verification.
9088

89+
## Running License Checks
90+
91+
File-level docblocks should follow the format demonstrated in `.docheader`. To
92+
check for conformity, use:
93+
94+
```console
95+
$ composer license-check
96+
```
97+
98+
This will flag files that are incorrect, which you can then update. Re-run the
99+
tool to verify your changes.
100+
91101
## Recommended Workflow for Contributions
92102

93103
Your first step is to establish a public repository from which we can
94104
pull your work into the master repository. We recommend using
95105
[GitHub](https://github.com), as that is where the component is already hosted.
96106

97-
1. Setup a [GitHub account](http://github.com/), if you haven't yet
98-
2. Fork the repository (http://github.com/zendframework/zend-expressive-zendviewrenderer)
107+
1. Setup a [GitHub account](https://github.com/), if you haven't yet
108+
2. Fork the repository (https://github.com/zendframework/zend-expressive-zendviewrenderer)
99109
3. Clone the canonical repository locally and enter it.
100110

101111
```console
102-
$ git clone git://github.com:zendframework/zend-expressive-zendviewrenderer.git
112+
$ git clone git://github.com/zendframework/zend-expressive-zendviewrenderer.git
103113
$ cd zend-expressive-zendviewrenderer
104114
```
105115

@@ -220,7 +230,6 @@ repository, we suggest doing some cleanup of these branches.
220230
```
221231

222232

223-
224233
## Conduct
225234

226235
Please see our [CONDUCT.md](CONDUCT.md) to understand expected behavior when interacting with others in the project.

LICENSE.md

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,28 @@
1-
Copyright (c) 2015, Zend Technologies USA, Inc.
1+
Copyright (c) 2015-2017, Zend Technologies USA, Inc.
2+
23
All rights reserved.
34

4-
Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
5+
Redistribution and use in source and binary forms, with or without modification,
6+
are permitted provided that the following conditions are met:
57

6-
- Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
8+
- Redistributions of source code must retain the above copyright notice,
9+
this list of conditions and the following disclaimer.
710

8-
- Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.
11+
- Redistributions in binary form must reproduce the above copyright notice,
12+
this list of conditions and the following disclaimer in the documentation
13+
and/or other materials provided with the distribution.
914

10-
- Neither the name of Zend Technologies USA, Inc. nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.
15+
- Neither the name of Zend Technologies USA, Inc. nor the names of its
16+
contributors may be used to endorse or promote products derived from this
17+
software without specific prior written permission.
1118

12-
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
19+
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
20+
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
21+
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
22+
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
23+
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
24+
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
25+
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
26+
ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27+
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
28+
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# zend-view PhpRenderer Integration for Expressive
22

33
[![Build Status](https://secure.travis-ci.org/zendframework/zend-expressive-zendviewrenderer.svg?branch=master)](https://secure.travis-ci.org/zendframework/zend-expressive-zendviewrenderer)
4+
[![Coverage Status](https://coveralls.io/repos/zendframework/zend-expressive-zendviewrenderer/badge.svg?branch=master)](https://coveralls.io/r/zendframework/zend-expressive-zendviewrenderer?branch=master)
45

56
[zend-view PhpRenderer](https://github.com/zendframework/zend-view) integration
67
for [Expressive](https://github.com/zendframework/zend-expressive).
@@ -33,5 +34,4 @@ To use view helpers, the `ZendViewRendererFactory`:
3334

3435
## Documentation
3536

36-
See the [zend-expressive](https://github.com/zendframework/zend-expressive/blob/master/doc/book)
37-
documentation tree, or browse online at http://zend-expressive.rtfd.org.
37+
See the Expressive [ZF View documentation](https://docs.zendframework.com/zend-expressive/features/template/zend-view/).

composer.json

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"middleware",
1010
"psr",
1111
"psr-7",
12-
"zf2"
12+
"zf"
1313
],
1414
"extra": {
1515
"branch-alias": {
@@ -19,18 +19,18 @@
1919
},
2020
"require": {
2121
"php": "^5.6 || ^7.0",
22-
"container-interop/container-interop": "^1.1",
23-
"psr/http-message": "^1.0",
24-
"zendframework/zend-expressive-helpers": "^1.1 || ^2.2 || ^3.0",
25-
"zendframework/zend-expressive-router": "^1.3.2 || ^2.0",
22+
"container-interop/container-interop": "^1.2",
23+
"psr/http-message": "^1.0.1",
24+
"zendframework/zend-expressive-helpers": "^1.4 || ^2.2 || ^3.0.1",
25+
"zendframework/zend-expressive-router": "^1.3.2 || ^2.1",
2626
"zendframework/zend-expressive-template": "^1.0.4",
27-
"zendframework/zend-servicemanager": "^2.7.5 || ^3.0.3",
27+
"zendframework/zend-servicemanager": "^2.7.8 || ^3.3",
2828
"zendframework/zend-view": "^2.8.1"
2929
},
3030
"require-dev": {
31-
"phpunit/phpunit": "^5.7",
32-
"zendframework/zend-coding-standard": "~1.0.0",
33-
"malukenho/docheader": "^0.1.5"
31+
"malukenho/docheader": "^0.1.5",
32+
"phpunit/phpunit": "^6.0.8 || ^5.7.15",
33+
"zendframework/zend-coding-standard": "~1.0.0"
3434
},
3535
"autoload": {
3636
"psr-4": {
@@ -45,12 +45,14 @@
4545
"scripts": {
4646
"check": [
4747
"@license-check",
48-
"@cs",
48+
"@cs-check",
4949
"@test"
5050
],
51-
"cs": "phpcs",
52-
"cs-fix": "phpcbf",
51+
"upload-coverage": "coveralls -v",
52+
"cs-check": "phpcs --colors",
53+
"cs-fix": "phpcbf --colors",
5354
"license-check": "docheader check src/ test/",
54-
"test": "phpunit --colors=always"
55+
"test": "phpunit --colors=always",
56+
"test-coverage": "phpunit --coverage-clover clover.xml"
5557
}
5658
}

0 commit comments

Comments
 (0)