Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Commit 1370c0b

Browse files
committed
Merge branch 'hotfix/server-url-doc-type'
Close #273
2 parents e0bd1b7 + e45f237 commit 1370c0b

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ Initial stable release.
2323
- [#268](https://github.com/zendframework/zend-expressive/pull/268) fixes the
2424
Pimple example within the `ServerUrlHelper` chapter of the documentation to
2525
use the Pimple v3 API instead of the v1 API.
26+
- [#273](https://github.com/zendframework/zend-expressive/pull/273) fixes the
27+
verbiage used in the `ServerUrlHelper` documentation regarding when to
28+
register the `ServerUrlMiddleware`; though the examples were correct, the
29+
verbiage was indicating the middleware should be piped following routing,
30+
rather than before.
2631

2732
## 1.0.0rc6 - 2016-01-18
2833

doc/book/helpers/server-url-helper.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ As such, you will need to:
4747

4848
- Register the `ServerUrlHelper` as a service in your container.
4949
- Register the `ServerUrlMiddleware` as a service in your container.
50-
- Register the `ServerUrlMiddleware` as pipeline middleware, immediately
51-
following the routing middleware.
50+
- Register the `ServerUrlMiddleware` as pipeline middleware, anytime
51+
before the routing middleware.
5252

5353
The following examples demonstrate registering the services.
5454

@@ -79,7 +79,7 @@ $container->set(
7979
);
8080
```
8181

82-
To register the `ServerUrlMiddleware` as pipeline middleware following the
82+
To register the `ServerUrlMiddleware` as pipeline middleware anytime before the
8383
routing middleware:
8484

8585
```php

0 commit comments

Comments
 (0)