Test error codes by changing the RuntimeException code

Author: geerteltink

test/Middleware/WhoopsErrorResponseGeneratorTest.php

@@ -75,7 +75,7 @@ public function testWritesResultsOfWhoopsExceptionsHandlingToResponse()
 
     public function testAddsRequestMetadataToWhoopsPrettyPageHandler()
     {
-        $error = new RuntimeException();
+        $error = new RuntimeException('STATUS_INTERNAL_SERVER_ERROR', StatusCode::STATUS_INTERNAL_SERVER_ERROR);
 
         $handler = $this->prophesize(PrettyPageHandler::class);
         $handler
@@ -120,7 +120,7 @@ public function testAddsRequestMetadataToWhoopsPrettyPageHandler()
 
     public function testJsonContentTypeResponseWithJsonResponseHandler()
     {
-        $error = new RuntimeException();
+        $error = new RuntimeException('STATUS_NOT_IMPLEMENTED', StatusCode::STATUS_NOT_IMPLEMENTED);
 
         $handler = $this->prophesize(JsonResponseHandler::class);
 
@@ -142,8 +142,8 @@ public function testJsonContentTypeResponseWithJsonResponseHandler()
         $this->request->getParsedBody()->willReturn([]);
 
         $this->response->withHeader('Content-Type', 'application/json')->will([$this->response, 'reveal']);
-        $this->response->withStatus(StatusCode::STATUS_IM_A_TEAPOT)->will([$this->response, 'reveal']);
-        $this->response->getStatusCode()->willReturn(StatusCode::STATUS_IM_A_TEAPOT);
+        $this->response->withStatus(StatusCode::STATUS_NOT_IMPLEMENTED)->will([$this->response, 'reveal']);
+        $this->response->getStatusCode()->willReturn(StatusCode::STATUS_NOT_IMPLEMENTED);
         $this->response->getBody()->will([$this->stream, 'reveal']);
 
         $this->stream->write('error')->shouldBeCalled();
@@ -155,25 +155,4 @@ public function testJsonContentTypeResponseWithJsonResponseHandler()
             $generator($error, $this->request->reveal(), $this->response->reveal())
         );
     }
-
-    public function testNonErrorStatusCodeIsSetTo500()
-    {
-        $error = new RuntimeException();
-
-        $this->whoops->getHandlers()->willReturn([]);
-        $this->whoops->handleException($error)->willReturn('WHOOPS');
-
-        $this->response->withStatus(StatusCode::STATUS_INTERNAL_SERVER_ERROR)->will([$this->response, 'reveal']);
-        $this->response->getBody()->will([$this->stream, 'reveal']);
-        $this->response->getStatusCode()->willReturn(StatusCode::STATUS_MOVED_PERMANENTLY);
-
-        $this->stream->write('WHOOPS')->shouldBeCalled();
-
-        $generator = new WhoopsErrorResponseGenerator($this->whoops->reveal());
-
-        $this->assertSame(
-            $this->response->reveal(),
-            $generator($error, $this->request->reveal(), $this->response->reveal())
-        );
-    }
 }