Implement RouteResultSubjectInterface

Updates `Application` to implement `Zend\Expressive\Router\RouteResultSubjectInterface`
explicitly. This involves:

- Removing `Zend\Expressive\RouteResultObserverInterface` (in favor of
  `Zend\Expressive\Router\RouteResultObserverInterface`).
- Updating typehints on `(attach|detach)RouteResultObserver()` to
  consume `Zend\Expressive\Router\RouteResultObserverInterface` instead
  of `Zend\Expressive\RouteResultObserverInterface`.
- Making `notifyRouteResultObservers()` public.
- Updating typehints in tests to consume `Zend\Expressive\Router\RouteResultObserverInterface`
  instead of `Zend\Expressive\RouteResultObserverInterface`.

Author: weierophinney

src/Application.php

@@ -29,7 +29,7 @@
  * @method Router\Route patch($path, $middleware, $name = null)
  * @method Router\Route delete($path, $middleware, $name = null)
  */
-class Application extends MiddlewarePipe
+class Application extends MiddlewarePipe implements Router\RouteResultSubjectInterface
 {
     /**
      * @var null|ContainerInterface
@@ -176,26 +176,38 @@ public function any($path, $middleware, $name = null)
     /**
      * Attach a route result observer.
      *
-     * @param RouteResultObserverInterface $observer
+     * @param Router\RouteResultObserverInterface $observer
      */
-    public function attachRouteResultObserver(RouteResultObserverInterface $observer)
+    public function attachRouteResultObserver(Router\RouteResultObserverInterface $observer)
     {
         $this->routeResultObservers[] = $observer;
     }
 
     /**
      * Detach a route result observer.
      *
-     * @param RouteResultObserverInterface $observer
+     * @param Router\RouteResultObserverInterface $observer
      */
-    public function detachRouteResultObserver(RouteResultObserverInterface $observer)
+    public function detachRouteResultObserver(Router\RouteResultObserverInterface $observer)
     {
         if (false === ($index = array_search($observer, $this->routeResultObservers, true))) {
             return;
         }
         unset($this->routeResultObservers[$index]);
     }
 
+    /**
+     * Notify all route result observers with the given route result.
+     *
+     * @param Router\RouteResult
+     */
+    public function notifyRouteResultObservers(Router\RouteResult $result)
+    {
+        foreach ($this->routeResultObservers as $observer) {
+            $observer->update($result);
+        }
+    }
+
     /**
      * Overload pipe() operation.
      *
@@ -692,16 +704,4 @@ private function marshalLazyErrorMiddlewareService($middleware, ContainerInterfa
             return $invokable($error, $request, $response, $next);
         };
     }
-
-    /**
-     * Notify all route result observers with the given route result.
-     *
-     * @param Router\RouteResult
-     */
-    private function notifyRouteResultObservers(Router\RouteResult $result)
-    {
-        foreach ($this->routeResultObservers as $observer) {
-            $observer->update($result);
-        }
-    }
 }

src/RouteResultObserverInterface.php

@@ -16,7 +16,7 @@
 use Zend\Diactoros\ServerRequest;
 use Zend\Expressive\Application;
 use Zend\Expressive\Router\RouteResult;
-use Zend\Expressive\RouteResultObserverInterface;
+use Zend\Expressive\Router\RouteResultObserverInterface;
 use Zend\Expressive\Router\RouterInterface;
 
 class RouteMiddlewareTest extends TestCase