Added tests for ErrorMiddlewarePipe behavior

This adds a test case for the ErrorMiddlewarePipe to verify that it:

- aggregates a middleware pipe instance
- dispatches the middleware composed in the middleware pipe instance
- but only those that are error middleware

Author: weierophinney

src/ErrorMiddlewarePipe.php

@@ -11,6 +11,7 @@
 
 use Psr\Http\Message\ServerRequestInterface as Request;
 use Psr\Http\Message\ResponseInterface as Response;
+use ReflectionProperty;
 use Zend\Stratigility\FinalHandler;
 use Zend\Stratigility\MiddlewarePipe;
 use Zend\Stratigility\Next;
@@ -81,7 +82,7 @@ public function __invoke($error, Request $request, Response $response, callable
     private function getInternalPipeline()
     {
         $r = new ReflectionProperty($this->pipeline, 'pipeline');
-        $r->setAccessible();
+        $r->setAccessible(true);
         return $r->getValue($this->pipeline);
     }
 }

test/ErrorMiddlewarePipeTest.php

@@ -0,0 +1,71 @@
+<?php
+/**
+ * Zend Framework (http://framework.zend.com/)
+ *
+ * @see       http://github.com/zendframework/zend-expressive for the canonical source repository
+ * @copyright Copyright (c) 2015-2016 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license   https://github.com/zendframework/zend-expressive/blob/master/LICENSE.md New BSD License
+ */
+
+namespace ZendTest\Expressive;
+
+use PHPUnit_Framework_TestCase as TestCase;
+use Psr\Http\Message\ServerRequestInterface as Request;
+use Psr\Http\Message\ResponseInterface as Response;
+use Psr\Http\Message\UriInterface as Uri;
+use Zend\Expressive\ErrorMiddlewarePipe;
+use Zend\Stratigility\MiddlewarePipe;
+
+class ErrorMiddlewarePipeTest extends TestCase
+{
+    public function setUp()
+    {
+        $this->internalPipe = new MiddlewarePipe();
+        $this->errorPipe = new ErrorMiddlewarePipe($this->internalPipe);
+    }
+
+    public function testWillDispatchErrorMiddlewareComposedInInternalPipeline()
+    {
+        $error = (object) ['error' => true];
+        $triggered = (object) [
+            'first' => false,
+            'second' => false,
+            'third' => false,
+        ];
+
+        $first = function ($err, $request, $response, $next) use ($error, $triggered) {
+            $this->assertSame($error, $err);
+            $triggered->first = true;
+            return $next($request, $response, $err);
+        };
+        $second = function ($request, $response, $next) use ($triggered) {
+            $triggered->second = true;
+            return $next($request, $response);
+        };
+        $third = function ($err, $request, $response, $next) use ($error, $triggered) {
+            $this->assertSame($error, $err);
+            $triggered->third = true;
+            return $response;
+        };
+
+        $this->internalPipe->pipe($first);
+        $this->internalPipe->pipe($second);
+        $this->internalPipe->pipe($third);
+
+        $uri = $this->prophesize(Uri::class);
+        $uri->getPath()->willReturn('/');
+        $request = $this->prophesize(Request::class);
+        $request->getUri()->willReturn($uri->reveal());
+        $response = $this->prophesize(Response::class);
+
+        $final = function ($request, $response, $err = null) {
+            $this->fail('Final handler should not be triggered');
+        };
+
+        $result = $this->errorPipe->__invoke($error, $request->reveal(), $response->reveal(), $final);
+        $this->assertSame($response->reveal(), $result);
+        $this->assertTrue($triggered->first);
+        $this->assertFalse($triggered->second);
+        $this->assertTrue($triggered->third);
+    }
+}