Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Commit 31a267f

Browse files
committed
Fixed CS issues
php-cs-fixer was improperly trying to fix the `marshalBadControllerEvent()` declaration, likely due to the trailing comment on the last argument. Moved the comment into a formal `@todo` annotation, allowing the ability to do a single-line method definition, fixing the CS issue.
1 parent 55b04db commit 31a267f

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/DispatchListener.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -232,18 +232,16 @@ protected function marshallControllerNotFoundEvent(
232232
/**
233233
* Marshal a bad controller exception event
234234
*
235+
* @todo Update $exception typehint to "Throwable" once PHP 7 requirement
236+
* is enforced
235237
* @param string $controllerName
236238
* @param MvcEvent $event
237239
* @param Application $application
238240
* @param \Exception|\Throwable $exception
239241
* @return mixed
240242
*/
241-
protected function marshalBadControllerEvent(
242-
$controllerName,
243-
MvcEvent $event,
244-
Application $application,
245-
$exception // @TODO clean up once PHP 7 requirement is enforced
246-
) {
243+
protected function marshalBadControllerEvent($controllerName, MvcEvent $event, Application $application, $exception)
244+
{
247245
$event->setName(MvcEvent::EVENT_DISPATCH_ERROR);
248246
$event->setError($application::ERROR_EXCEPTION);
249247
$event->setController($controllerName);

0 commit comments

Comments
 (0)