Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Commit 7792a1e

Browse files
committed
Removed invalid test cases
The test cases removed are tested implicitly when retrieving aliases; however, they can never be retrieved directly, as they will not resolve to fully qualified class names. (When retrieving by alias, the FQCN is passed as the "requested name", which is why the factory works ever.)
1 parent 167bf67 commit 7792a1e

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

test/Router/Console/SimpleRouteStackTest.php

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
namespace ZendTest\Mvc\Router\Console;
1111

1212
use PHPUnit_Framework_TestCase as TestCase;
13-
use ReflectionClass;
1413
use Zend\Mvc\Router\Console\Catchall;
1514
use Zend\Mvc\Router\Console\Simple;
1615
use Zend\Mvc\Router\Console\SimpleRouteStack;
@@ -23,7 +22,7 @@ public function routeTypeProvider()
2322
$catchallOpts = ['defaults' => []];
2423
$simpleOpts = ['route' => 'test'];
2524

26-
$data = [
25+
return [
2726
'catchall' => ['catchall', $catchallOpts, Catchall::class],
2827
'catchAll' => ['catchAll', $catchallOpts, Catchall::class],
2928
'Catchall' => ['Catchall', $catchallOpts, Catchall::class],
@@ -34,15 +33,6 @@ public function routeTypeProvider()
3433
Catchall::class => [Catchall::class, $catchallOpts, Catchall::class],
3534
Simple::class => [Simple::class, $simpleOpts, Simple::class],
3635
];
37-
38-
// Two additional cases under zend-servicemanager v2:
39-
$r = new ReflectionClass(ServiceManager::class);
40-
if (! $r->hasMethod('configure')) {
41-
$data['zendmvcrouterconsolecatchall'] = ['zendmvcrouterconsolecatchall', $catchallOpts, Catchall::class];
42-
$data['zendmvcrouterconsolesimple'] = ['zendmvcrouterconsolesimple', $simpleOpts, Simple::class];
43-
}
44-
45-
return $data;
4636
}
4737

4838
/**

0 commit comments

Comments
 (0)