Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Commit 814acd2

Browse files
committed
Merge pull request #208 from Koopzington/new-coding-standard
New coding standard Conflicts: composer.lock
2 parents 2d45de0 + 4df4f43 commit 814acd2

File tree

56 files changed

+399
-738
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+399
-738
lines changed

.php_cs

Lines changed: 0 additions & 45 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,24 +77,24 @@ To do so:
7777

7878
## Running Coding Standards Checks
7979

80-
This component uses [php-cs-fixer](http://cs.sensiolabs.org/) for coding
80+
This component uses [phpcs](https://github.com/squizlabs/PHP_CodeSniffer) for coding
8181
standards checks, and provides configuration for our selected checks.
82-
`php-cs-fixer` is installed by default via Composer.
82+
`phpcs` is installed by default via Composer.
8383

8484
To run checks only:
8585

8686
```console
87-
$ ./vendor/bin/php-cs-fixer fix . -v --diff --dry-run --config-file=.php_cs
87+
$ composer cs-check
8888
```
8989

90-
To have `php-cs-fixer` attempt to fix problems for you, omit the `--dry-run`
91-
flag:
90+
`phpcs` also includes a tool for fixing most CS violations, `phpcbf`:
91+
9292

9393
```console
94-
$ ./vendor/bin/php-cs-fixer fix . -v --diff --config-file=.php_cs
94+
$ composer cs-fix
9595
```
9696

97-
If you allow php-cs-fixer to fix CS issues, please re-run the tests to ensure
97+
If you allow `phpcbf` to fix CS issues, please re-run the tests to ensure
9898
they pass, and make sure you add and commit the changes after verification.
9999

100100
## Recommended Workflow for Contributions

composer.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
"require-dev": {
2727
"zendframework/zend-json": "^2.6.1 || ^3.0",
2828
"zendframework/zend-psr7bridge": "^0.2",
29-
"fabpot/php-cs-fixer": "1.7.*",
30-
"phpunit/phpunit": "^4.5"
29+
"phpunit/phpunit": "^4.6",
30+
"zendframework/zend-coding-standard": "~1.0.0"
3131
},
3232
"suggest": {
3333
"zendframework/zend-json": "(^2.6.1 || ^3.0) To auto-deserialize JSON body content in AbstractRestfulController extensions, when json_decode is unavailable",
@@ -56,10 +56,10 @@
5656
"@cs-check",
5757
"@test"
5858
],
59-
"upload-coverage": "coveralls -v",
60-
"cs-check": "php-cs-fixer --version && php-cs-fixer fix -v --diff --dry-run",
61-
"cs-fix": "php-cs-fixer fix -v",
62-
"test": "phpunit",
63-
"test-coverage": "phpunit --coverage-clover clover.xml"
59+
"cs-check": "phpcs",
60+
"cs-fix": "phpcbf",
61+
"test": "phpunit --colors=always",
62+
"test-coverage": "phpunit --colors=always --coverage-clover clover.xml",
63+
"upload-coverage": "coveralls -v"
6464
}
6565
}

0 commit comments

Comments
 (0)