Merge branch 'feature/remove-zend-navigation' into develop

Close #125

Author: weierophinney

CHANGELOG.md

@@ -91,6 +91,10 @@ for full details on how to migrate your v2 application.
   `FormElementManager`, `FormAnnotationBuilder`, and the
   `FormAbstractServiceFactory`. The functionality is now exposed directly by the
   zend-form component.
+- [#125](https://github.com/zendframework/zend-mvc/pull/125) removes the
+  functionality from the `ViewHelperManager` factory for fetching configuration
+  classes from other components and using them to configure the instance. In all
+  cases, this is now done by the components themselves.
 
 ### Fixed
 

src/Service/ViewHelperManagerFactory.php

@@ -11,7 +11,6 @@
 
 use Interop\Container\ContainerInterface;
 use Zend\Router\RouteMatch;
-use Zend\ServiceManager\ConfigInterface;
 use Zend\ServiceManager\Exception\ServiceNotCreatedException;
 use Zend\View\Helper as ViewHelper;
 use Zend\View\HelperPluginManager;
@@ -29,7 +28,6 @@ class ViewHelperManagerFactory extends AbstractPluginManagerFactory
      * @var array
      */
     protected $defaultHelperMapClasses = [
-        'Zend\Navigation\View\HelperConfig',
     ];
 
     /**
@@ -45,47 +43,12 @@ public function __invoke(ContainerInterface $container, $requestedName, array $o
         $options['factories'] = isset($options['factories']) ? $options['factories'] : [];
         $plugins = parent::__invoke($container, $requestedName, $options);
 
-        // Configure default helpers from other components
-        $plugins = $this->configureHelpers($plugins);
-
         // Override plugin factories
         $plugins = $this->injectOverrideFactories($plugins, $container);
 
         return $plugins;
     }
 
-    /**
-     * Configure helpers from other components.
-     *
-     * Loops through the list of default helper configuration classes, and uses
-     * each to configure the helper plugin manager.
-     *
-     * @param HelperPluginManager $plugins
-     * @return HelperPluginManager
-     */
-    private function configureHelpers(HelperPluginManager $plugins)
-    {
-        foreach ($this->defaultHelperMapClasses as $configClass) {
-            if (! is_string($configClass) || ! class_exists($configClass)) {
-                continue;
-            }
-
-            $config = new $configClass();
-
-            if (! $config instanceof ConfigInterface) {
-                throw new ServiceNotCreatedException(sprintf(
-                    'Invalid service manager configuration class provided; received "%s", expected class implementing %s',
-                    $configClass,
-                    ConfigInterface::class
-                ));
-            }
-
-            $config->configureServiceManager($plugins);
-        }
-
-        return $plugins;
-    }
-
     /**
      * Inject override factories into the plugin manager.
      *