Merge pull request #20 from akrabat/remove-resources

Create a response when a resource is in the trace

Author: weierophinney

src/ProblemDetailsResponseFactory.php

@@ -229,6 +229,12 @@ public function createResponse(
         ];
 
         if ($additional) {
+            // ensure payload can be json_encoded
+            array_walk_recursive($additional, function (&$value) {
+                if (is_resource($value)) {
+                    $value = print_r($value, true) . ' of type ' . get_resource_type($value);
+                }
+            });
             $payload = array_merge($additional, $payload);
         }
 

test/ProblemDetailsResponseFactoryTest.php

@@ -135,6 +135,34 @@ public function testCreateResponseFromThrowableWillPullDetailsFromProblemDetails
         $this->assertSame('bar', $payload['foo']);
     }
 
+    /**
+     * @dataProvider acceptHeaders
+     */
+    public function testCreateResponseRemovesResourcesFromInputData(string $header, string $expectedType) : void
+    {
+        $this->request->getHeaderLine('Accept')->willReturn($header);
+
+        $fh = fopen(__FILE__, 'r');
+        $response = $this->factory->createResponse(
+            $this->request->reveal(),
+            500,
+            'Unknown error occurred',
+            'Title',
+            'Type',
+            [
+                'args' => [
+                    'resource' => $fh,
+                ]
+            ]
+        );
+        fclose($fh);
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+        $this->assertEquals($expectedType, $response->getHeaderLine('Content-Type'));
+
+        $this->assertNotEmpty((string)$response->getBody(), 'Body is missing');
+    }
+
     public function testFactoryRaisesExceptionIfBodyFactoryDoesNotReturnStream() : void
     {
         $this->request->getHeaderLine('Accept')->willReturn('application/json');