Use empty() instead of ! to test for empty string

weierophinney · weierophinney · commit d347a8f77d9c · 2017-07-31T15:41:14.000-05:00
More accurate semantics (testing for an empty string)
diff --git a/src/ProblemDetailsMiddleware.php b/src/ProblemDetailsMiddleware.php
@@ -55,7 +55,7 @@ public function process(ServerRequestInterface $request, DelegateInterface $dele
     private function canActAsErrorHandler(ServerRequestInterface $request) : bool
     {
         $accept = $request->getHeaderLine('Accept') ?: '*/*';
-        if (! $accept) {
+        if (empty($accept)) {
             return false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public function process(ServerRequestInterface $request, DelegateInterface $dele`
`55`	`55`	`private function canActAsErrorHandler(ServerRequestInterface $request) : bool`
`56`	`56`	`{`
`57`	`57`	`$accept = $request->getHeaderLine('Accept') ?: '/';`
`58`		`- if (! $accept) {`
	`58`	`+ if (empty($accept)) {`
`59`	`59`	`return false;`
`60`	`60`	`}`
`61`	`61`