Merge branch 'hotfix/24-strict-types' into release-1.0.0

weierophinney · weierophinney · commit ea00e6a25145 · 2017-12-12T15:27:28.000-06:00
Close #24
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,7 +15,10 @@ Versions 0.3.0 and prior were released as "weierophinney/problem-details".
 
 ### Changed
 
-- Nothing.
+- [#24](https://github.com/zendframework/zend-problem-details/pull/24)
+  updates all classes to use scalar and return type hints, including nullable
+  and void types. If you were extending classes within an earlier release, you
+  may need to update signatures of any methods you override.
 
 ### Deprecated
 
diff --git a/src/ConfigProvider.php b/src/ConfigProvider.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace Zend\ProblemDetails;
 
 /**
diff --git a/src/Exception/CommonProblemDetailsExceptionTrait.php b/src/Exception/CommonProblemDetailsExceptionTrait.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace Zend\ProblemDetails\Exception;
 
 /**
diff --git a/src/Exception/ExceptionInterface.php b/src/Exception/ExceptionInterface.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace Zend\ProblemDetails\Exception;
 
 /**
diff --git a/src/Exception/InvalidResponseBodyException.php b/src/Exception/InvalidResponseBodyException.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace Zend\ProblemDetails\Exception;
 
 use RuntimeException;
diff --git a/src/Exception/ProblemDetailsExceptionInterface.php b/src/Exception/ProblemDetailsExceptionInterface.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace Zend\ProblemDetails\Exception;
 
 use JsonSerializable;
diff --git a/src/ProblemDetailsMiddleware.php b/src/ProblemDetailsMiddleware.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace Zend\ProblemDetails;
 
 use ErrorException;
diff --git a/src/ProblemDetailsMiddlewareFactory.php b/src/ProblemDetailsMiddlewareFactory.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace Zend\ProblemDetails;
 
 use Psr\Container\ContainerInterface;
diff --git a/src/ProblemDetailsNotFoundHandler.php b/src/ProblemDetailsNotFoundHandler.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace Zend\ProblemDetails;
 
 use Interop\Http\Server\MiddlewareInterface;
diff --git a/src/ProblemDetailsNotFoundHandlerFactory.php b/src/ProblemDetailsNotFoundHandlerFactory.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace Zend\ProblemDetails;
 
 use Psr\Container\ContainerInterface;
diff --git a/src/ProblemDetailsResponseFactory.php b/src/ProblemDetailsResponseFactory.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace Zend\ProblemDetails;
 
 use Closure;
diff --git a/src/ProblemDetailsResponseFactoryFactory.php b/src/ProblemDetailsResponseFactoryFactory.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace Zend\ProblemDetails;
 
 use Psr\Container\ContainerInterface;
diff --git a/test/ConfigProviderTest.php b/test/ConfigProviderTest.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace ZendTest\ProblemDetails;
 
 use PHPUnit\Framework\TestCase;
diff --git a/test/Exception/ProblemDetailsExceptionInterfaceTest.php b/test/Exception/ProblemDetailsExceptionInterfaceTest.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace ZendTest\ProblemDetails\Exception;
 
 use PHPUnit\Framework\TestCase;
diff --git a/test/ProblemDetailsAssertionsTrait.php b/test/ProblemDetailsAssertionsTrait.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace ZendTest\ProblemDetails;
 
 use Psr\Http\Message\ResponseInterface;
diff --git a/test/ProblemDetailsMiddlewareFactoryTest.php b/test/ProblemDetailsMiddlewareFactoryTest.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace ZendTest\ProblemDetails;
 
 use PHPUnit\Framework\TestCase;
diff --git a/test/ProblemDetailsMiddlewareTest.php b/test/ProblemDetailsMiddlewareTest.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace ZendTest\ProblemDetails;
 
 use ErrorException;
diff --git a/test/ProblemDetailsNotFoundHandlerFactoryTest.php b/test/ProblemDetailsNotFoundHandlerFactoryTest.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace ZendTest\ProblemDetails;
 
 use PHPUnit\Framework\TestCase;
diff --git a/test/ProblemDetailsNotFoundHandlerTest.php b/test/ProblemDetailsNotFoundHandlerTest.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace ZendTest\ProblemDetails;
 
 use Interop\Http\Server\RequestHandlerInterface;
diff --git a/test/ProblemDetailsResponseFactoryFactoryTest.php b/test/ProblemDetailsResponseFactoryFactoryTest.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace ZendTest\ProblemDetails;
 
 use Closure;
diff --git a/test/ProblemDetailsResponseFactoryTest.php b/test/ProblemDetailsResponseFactoryTest.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace ZendTest\ProblemDetails;
 
 use Exception;
@@ -214,7 +216,7 @@ public function testFactoryRaisesExceptionIfBodyFactoryDoesNotReturnStream() : v
         });
 
         $this->expectException(InvalidResponseBodyException::class);
-        $factory->createResponse($this->request->reveal(), '500', 'This is an error');
+        $factory->createResponse($this->request->reveal(), 500, 'This is an error');
     }
 
     public function testFactoryGeneratesXmlResponseIfNegotiationFails() : void
@@ -271,7 +273,7 @@ public function testFragileDataInExceptionMessageShouldBeHiddenInResponseBodyInN
 
     public function testExceptionCodeShouldBeIgnoredAnd500ServedInResponseBodyInNonDebugMode()
     {
-        $exception = new Exception(null, 400);
+        $exception = new Exception('', 400);
 
         $response = $this->factory->createResponseFromThrowable($this->request->reveal(), $exception);
 
diff --git a/test/TestAsset/RuntimeException.php b/test/TestAsset/RuntimeException.php
@@ -5,6 +5,8 @@
  * @license   https://github.com/zendframework/zend-problem-details/blob/master/LICENSE.md New BSD License
  */
 
+declare(strict_types=1);
+
 namespace ZendTest\ProblemDetails\TestAsset;
 
 use RuntimeException as BaseRuntimeException;
