Merge pull request #234 from malukenho/enhancement/use-imported-function

Avoid usage of leading `\` on imported functions

Author: weierophinney

src/AbstractFactory/ConfigAbstractFactory.php

@@ -19,21 +19,20 @@
 
 final class ConfigAbstractFactory implements AbstractFactoryInterface
 {
-
     /**
      * Factory can create the service if there is a key for it in the config
      *
      * {@inheritdoc}
      */
     public function canCreate(\Interop\Container\ContainerInterface $container, $requestedName)
     {
-        if (! $container->has('config') || ! \array_key_exists(self::class, $container->get('config'))) {
+        if (! $container->has('config') || ! array_key_exists(self::class, $container->get('config'))) {
             return false;
         }
         $config = $container->get('config');
         $dependencies = $config[self::class];
 
-        return \is_array($dependencies) && \array_key_exists($requestedName, $dependencies);
+        return is_array($dependencies) && array_key_exists($requestedName, $dependencies);
     }
 
     /**
@@ -47,31 +46,31 @@ public function __invoke(\Interop\Container\ContainerInterface $container, $requ
 
         $config = $container->get('config');
 
-        if (! (\is_array($config) || $config instanceof ArrayObject)) {
+        if (! (is_array($config) || $config instanceof ArrayObject)) {
             throw new ServiceNotCreatedException('Config must be an array or an instance of ArrayObject');
         }
 
-        if (! \array_key_exists(self::class, $config)) {
+        if (! array_key_exists(self::class, $config)) {
             throw new ServiceNotCreatedException('Cannot find a `' . self::class . '` key in the config array');
         }
 
         $dependencies = $config[self::class];
 
-        if (! \is_array($dependencies)
-            || ! \array_key_exists($requestedName, $dependencies)
-            || ! \is_array($dependencies[$requestedName])
+        if (! is_array($dependencies)
+            || ! array_key_exists($requestedName, $dependencies)
+            || ! is_array($dependencies[$requestedName])
         ) {
             throw new ServiceNotCreatedException('Dependencies config must exist and be an array');
         }
 
         $serviceDependencies = $dependencies[$requestedName];
 
-        if ($serviceDependencies !== \array_values(\array_map('strval', $serviceDependencies))) {
-            $problem = \json_encode(\array_map('gettype', $serviceDependencies));
+        if ($serviceDependencies !== array_values(array_map('\strval', $serviceDependencies))) {
+            $problem = json_encode(array_map('\gettype', $serviceDependencies));
             throw new ServiceNotCreatedException('Service message must be an array of strings, ' . $problem . ' given');
         }
 
-        $arguments = \array_map([$container, 'get'], $serviceDependencies);
+        $arguments = array_map([$container, 'get'], $serviceDependencies);
 
         return new $requestedName(...$arguments);
     }

src/Tool/ConfigDumperCommand.php

@@ -12,7 +12,6 @@
 
 use function array_shift;
 use function class_exists;
-use function count;
 use function dirname;
 use function file_exists;
 use function file_put_contents;

src/Tool/FactoryCreatorCommand.php

@@ -12,7 +12,6 @@
 
 use function array_shift;
 use function class_exists;
-use function count;
 use function in_array;
 use function sprintf;