Similified canCreate so it stops failing silently, the failure now happens in the __invoke method to ensure we dont get confused users wondering why this abstract factory isnt firing

Author: GeeH

src/AbstractFactory/ConfigAbstractFactory.php

@@ -28,17 +28,7 @@ public function canCreate(\Interop\Container\ContainerInterface $container, $req
         $config = $container->get('config');
         $dependencies = $config[self::class];
 
-        // config must be array, and have a key for the requested name that's value is also an array
-        if (!is_array($dependencies)
-            || !array_key_exists($requestedName, $dependencies)
-            || !is_array($dependencies[$requestedName])
-        ) {
-            return false;
-        }
-
-        // we can only create this service if the config is an array of strings
-        return $dependencies[$requestedName] === array_values(array_map('strval', $dependencies[$requestedName]));
-
+        return is_array($dependencies) && array_key_exists($requestedName, $dependencies);
     }
 
     /**

test/AbstractFactory/ConfigAbstractFactoryTest.php

@@ -20,7 +20,7 @@
 class ConfigAbstractFactoryTest extends \PHPUnit_Framework_TestCase
 {
 
-    public function testCanCreateReturnsFalseIfDependencyNotArrays()
+    public function testCanCreateReturnsTrueIfDependencyNotArrays()
     {
         $abstractFactory = new ConfigAbstractFactory();
         $serviceManager = new ServiceManager();
@@ -42,7 +42,7 @@ public function testCanCreateReturnsFalseIfDependencyNotArrays()
                 ]
             ]
         );
-        self::assertFalse($abstractFactory->canCreate($serviceManager, InvokableObject::class));
+        self::assertTrue($abstractFactory->canCreate($serviceManager, InvokableObject::class));
 
         $serviceManager->setAllowOverride(true);
         $serviceManager->setService(
@@ -58,7 +58,7 @@ public function testCanCreateReturnsFalseIfDependencyNotArrays()
                 ]
             ]
         );
-        self::assertFalse($abstractFactory->canCreate($serviceManager, InvokableObject::class));
+        self::assertTrue($abstractFactory->canCreate($serviceManager, InvokableObject::class));
 
     }