Additional test case for canCreate when no constructor for class

Author: asgrim

src/AbstractFactory/ReflectionBasedAbstractFactory.php

@@ -141,11 +141,7 @@ private function canCallConstructor(string $requestedName) : bool
     {
         $constructor = (new ReflectionClass($requestedName))->getConstructor();
 
-        if ($constructor === null) {
-            return true;
-        }
-
-        return $constructor->isPublic();
+        return $constructor === null || $constructor->isPublic();
     }
 
     /**

test/AbstractFactory/ReflectionBasedAbstractFactoryTest.php

@@ -51,6 +51,17 @@ public function testCanCreateReturnsFalseWhenConstructorIsPrivate()
         );
     }
 
+    public function testCanCreateReturnsTrueWhenClassHasNoConstructor() : void
+    {
+        self::assertTrue(
+            (new ReflectionBasedAbstractFactory())->canCreate(
+                $this->container->reveal(),
+                TestAsset\ClassWithNoConstructor::class
+            ),
+            'ReflectionBasedAbstractFactory should be able to instantiate a class without a constructor'
+        );
+    }
+
     public function testFactoryInstantiatesClassDirectlyIfItHasNoConstructor()
     {
         $factory = new ReflectionBasedAbstractFactory();