Renamed new test cases to describe behavior tested

weierophinney · weierophinney · commit 3d6365e11623 · 2016-09-01T13:50:42.000-05:00
diff --git a/test/CommonServiceLocatorBehaviorsTrait.php b/test/CommonServiceLocatorBehaviorsTrait.php
@@ -140,7 +140,7 @@ public function testCanCreateServiceWithAbstractFactory()
         $serviceManager->get(DateTime::class);
     }
 
-    public function testCallTwiceWithDifferentInstanceAbstractFactories()
+    public function testAllowsMultipleInstancesOfTheSameAbstractFactory()
     {
         CallTimesAbstractFactory::setCallTimes(0);
 
@@ -160,10 +160,7 @@ public function testCallTwiceWithDifferentInstanceAbstractFactories()
         $this->assertEquals(2, CallTimesAbstractFactory::getCallTimes());
     }
 
-    /**
-     * A new test with the same instance of `CallTimesAbstractFactory` should be provided.
-     */
-    public function testCallOnlyOnceWithSameInstanceAbstractFactory()
+    public function testWillReUseAnExistingNamedAbstractFactoryInstance()
     {
         CallTimesAbstractFactory::setCallTimes(0);
 

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ public function testCanCreateServiceWithAbstractFactory()`
`140`	`140`	`$serviceManager->get(DateTime::class);`
`141`	`141`	`}`
`142`	`142`
`143`		`- public function testCallTwiceWithDifferentInstanceAbstractFactories()`
	`143`	`+ public function testAllowsMultipleInstancesOfTheSameAbstractFactory()`
`144`	`144`	`{`
`145`	`145`	`CallTimesAbstractFactory::setCallTimes(0);`
`146`	`146`
`@@ -160,10 +160,7 @@ public function testCallTwiceWithDifferentInstanceAbstractFactories()`
`160`	`160`	`$this->assertEquals(2, CallTimesAbstractFactory::getCallTimes());`
`161`	`161`	`}`
`162`	`162`
`163`		`- /**`
`164`		- * A new test with the same instance of `CallTimesAbstractFactory` should be provided.
`165`		`- */`
`166`		`- public function testCallOnlyOnceWithSameInstanceAbstractFactory()`
	`163`	`+ public function testWillReUseAnExistingNamedAbstractFactoryInstance()`
`167`	`164`	`{`
`168`	`165`	`CallTimesAbstractFactory::setCallTimes(0);`
`169`	`166`