#83 - cyclic dependencies should eagerly cause a crash to prevent silly mistakes with aliases

Author: Ocramius

test/CommonServiceLocatorBehaviorsTrait.php

@@ -16,6 +16,7 @@
 use stdClass;
 use Zend\ServiceManager\Exception\ContainerModificationsNotAllowedException;
 use Zend\ServiceManager\Exception\InvalidArgumentException;
+use Zend\ServiceManager\Exception\InvalidServiceException;
 use Zend\ServiceManager\Exception\ServiceNotCreatedException;
 use Zend\ServiceManager\Exception\ServiceNotFoundException;
 use Zend\ServiceManager\Factory\FactoryInterface;
@@ -790,15 +791,15 @@ public function testCanRetrieveParentContainerViaGetServiceLocatorWithDeprecatio
      */
     public function testCrashesOnCyclicAliases()
     {
+        $this->setExpectedException(InvalidServiceException::class);
+
         $serviceManager = $this->createContainer([
             'aliases' => [
                 'a' => 'b',
                 'b' => 'a',
             ],
         ]);
 
-        $this->setExpectedException(ServiceNotFoundException::class);
-
         $serviceManager->get('b');
     }
 }