This repository was archived by the owner on Feb 6, 2020. It is now read-only.
File tree Expand file tree Collapse file tree 1 file changed +1
-8
lines changed Expand file tree Collapse file tree 1 file changed +1
-8
lines changed Original file line number Diff line number Diff line change @@ -345,7 +345,6 @@ public function configure(array $config)
345
345
$ factories = $ this ->createFactoriesForInvokables ($ config ['invokables ' ]);
346
346
347
347
if (! empty ($ aliases )) {
348
- // @todo: This is wrong! These aliases are 'resolved' already
349
348
$ config ['aliases ' ] = (isset ($ config ['aliases ' ]))
350
349
? \array_merge ($ config ['aliases ' ], $ aliases )
351
350
: $ aliases ;
@@ -520,6 +519,7 @@ public function setShared($name, $flag)
520
519
*
521
520
* @param string[]|Initializer\InitializerInterface[]|callable[] $initializers
522
521
*
522
+ * @return void
523
523
*/
524
524
private function resolveInitializer ($ initializer )
525
525
{
@@ -927,13 +927,6 @@ private function doSetAlias($alias, $target)
927
927
/**
928
928
* Instantiate abstract factories for to avoid checks during service construction.
929
929
*
930
- * @todo: To construct to avoid is not really an optimization, it's lazyness
931
- * AbstractFactories are shared services. Make sure that has() is guarded against
932
- * numerical parameters. Handle AbstractFactories as any other shared services.
933
- *
934
- * @todo: Implement a has() and get() logic which unifies the several arrays
935
- * It is a desaster to isset(blah) several times on each request.
936
- *
937
930
* @param string[]|Factory\AbstractFactoryInterface[] $abstractFactories
938
931
*
939
932
* @return void
You can’t perform that action at this time.
0 commit comments