Skip to content
This repository was archived by the owner on Feb 6, 2020. It is now read-only.

Commit 4032bb0

Browse files
author
fhein
committed
Removed @todos.
1 parent 0e6eeb7 commit 4032bb0

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

src/ServiceManager.php

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,6 @@ public function configure(array $config)
345345
$factories = $this->createFactoriesForInvokables($config['invokables']);
346346

347347
if (! empty($aliases)) {
348-
// @todo: This is wrong! These aliases are 'resolved' already
349348
$config['aliases'] = (isset($config['aliases']))
350349
? \array_merge($config['aliases'], $aliases)
351350
: $aliases;
@@ -520,6 +519,7 @@ public function setShared($name, $flag)
520519
*
521520
* @param string[]|Initializer\InitializerInterface[]|callable[] $initializers
522521
*
522+
* @return void
523523
*/
524524
private function resolveInitializer($initializer)
525525
{
@@ -927,13 +927,6 @@ private function doSetAlias($alias, $target)
927927
/**
928928
* Instantiate abstract factories for to avoid checks during service construction.
929929
*
930-
* @todo: To construct to avoid is not really an optimization, it's lazyness
931-
* AbstractFactories are shared services. Make sure that has() is guarded against
932-
* numerical parameters. Handle AbstractFactories as any other shared services.
933-
*
934-
* @todo: Implement a has() and get() logic which unifies the several arrays
935-
* It is a desaster to isset(blah) several times on each request.
936-
*
937930
* @param string[]|Factory\AbstractFactoryInterface[] $abstractFactories
938931
*
939932
* @return void

0 commit comments

Comments
 (0)