Removed $checkAbstractFactories flag from has()

The flag breaks the LSP, and requires that a user know how a given
service might be configured inside the container. Removing it provides
easier interoperability, and removes unexpected false negative lookups.

Author: weierophinney

src/ServiceManager.php

@@ -211,12 +211,12 @@ public function build($name, array $options = null)
     /**
      * {@inheritDoc}
      */
-    public function has($name, $checkAbstractFactories = false)
+    public function has($name)
     {
         $name  = isset($this->resolvedAliases[$name]) ? $this->resolvedAliases[$name] : $name;
         $found = isset($this->services[$name]) || isset($this->factories[$name]);
 
-        if ($found || !$checkAbstractFactories) {
+        if ($found) {
             return $found;
         }
 

test/CommonServiceLocatorBehaviorsTrait.php

@@ -156,19 +156,7 @@ public function testCanCreateServiceWithAlias()
         $this->assertFalse($serviceManager->has('baz'));
     }
 
-    public function testCanCheckServiceExistenceWithoutCheckingAbstractFactories()
-    {
-        $serviceManager = $this->createContainer([
-            'factories' => [
-                stdClass::class => InvokableFactory::class
-            ]
-        ]);
-
-        $this->assertTrue($serviceManager->has(stdClass::class));
-        $this->assertFalse($serviceManager->has(DateTime::class));
-    }
-
-    public function testCanCheckServiceExistenceWithCheckingAbstractFactories()
+    public function testCheckingServiceExistenceWithChecksAgainstAbstractFactories()
     {
         $serviceManager = $this->createContainer([
             'factories' => [
@@ -179,8 +167,8 @@ public function testCanCheckServiceExistenceWithCheckingAbstractFactories()
             ]
         ]);
 
-        $this->assertTrue($serviceManager->has(stdClass::class, true));
-        $this->assertTrue($serviceManager->has(DateTime::class, true));
+        $this->assertTrue($serviceManager->has(stdClass::class));
+        $this->assertTrue($serviceManager->has(DateTime::class));
     }
 
     public function testBuildNeverSharesInstances()
@@ -322,23 +310,6 @@ public function testHasReturnsTrueIfFactoryIsConfigured()
         $this->assertTrue($serviceManager->has(stdClass::class));
     }
 
-    /**
-     * @group has
-     */
-    public function testHasDoesNotCheckAbstractFactoriesByDefault()
-    {
-        $serviceManager = $this->createContainer([
-            'factories' => [
-                stdClass::class => InvokableFactory::class,
-            ],
-            'abstract_factories' => [
-                new SimpleAbstractFactory(),
-            ],
-        ]);
-
-        $this->assertFalse($serviceManager->has(DateTime::class));
-    }
-
     public function abstractFactories()
     {
         return [
@@ -351,15 +322,15 @@ public function abstractFactories()
      * @group has
      * @dataProvider abstractFactories
      */
-    public function testHasCanCheckAbstractFactoriesWhenRequested($abstractFactory, $expected)
+    public function testHasChecksAgainstAbstractFactories($abstractFactory, $expected)
     {
         $serviceManager = $this->createContainer([
             'abstract_factories' => [
                 $abstractFactory,
             ],
         ]);
 
-        $this->assertSame($expected, $serviceManager->has(DateTime::class, true));
+        $this->assertSame($expected, $serviceManager->has(DateTime::class));
     }
 
     /**