Skip to content
This repository was archived by the owner on Feb 6, 2020. It is now read-only.

Commit 7afbd2e

Browse files
authored
Merge pull request #197 from webimpress/drop-php-5.6-and-7
Drop PHP 5.6 and 7.0
2 parents e17f320 + de949c3 commit 7afbd2e

18 files changed

+3211
-285
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ tmp/
1111
zf-mkdoc-theme/
1212

1313
clover.xml
14-
composer.lock
1514
coveralls-upload.json
1615
phpunit.xml
1716
vendor

.travis.yml

Lines changed: 41 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -15,44 +15,64 @@ cache:
1515

1616
env:
1717
global:
18-
- SITE_URL: https://zendframework.github.io/zend-servicemanager
19-
- GH_USER_NAME: "Matthew Weier O'Phinney"
20-
- GH_USER_EMAIL: [email protected]
21-
- GH_REF: github.com/zendframework/zend-servicemanager.git
18+
- COMPOSER_ARGS="--no-interaction"
19+
- COVERAGE_DEPS="satooshi/php-coveralls"
20+
- SITE_URL="https://zendframework.github.io/zend-servicemanager"
21+
- GH_USER_NAME="Matthew Weier O'Phinney"
22+
- GH_USER_EMAIL="[email protected]"
23+
- GH_REF="github.com/zendframework/zend-servicemanager.git"
2224
- secure: "KoLcNj22t668IhAhm5ej6DNf23waoGrZpQ1kmuq5ptTqsXjFjy/cjOJCvWOeRX62Tl2kjc7co9UeK0f91osZ2Wq7HLb+1bIXX5SrB6SfyPUajCQtCtu0xGgEKZfuQwzLWSYoR3tsaD6vqgMjKwwst10d+AyICjdLNu9dHtdu9HpozZtK3kM9+0FwMOiRqFEND2GY05oVYXOrzgu1xNmE1YEGpjKzqqBNpqFOP4W+OnTMRTQcyrlbFzOFvAip7X3GGw9iUSnSzZTnIOWJgMdah8/eFqhrPO8O73faW+/v3ZTxdwupOEZyg7s3TD6+W9rjmN+TgOZEP484PcSlUc6sXA4QM4iL8xthG3bWk8+CDrsnuQmunrXz7T5xUEHs/7B8NuGJ8yT89fMCYGySERKIfCx17+N9kP/848A/+39LE1NIlTxnaPISfm9WMNG67xsEKyJluC/YataPGl0zZ6/7Q7w1oDYvjhsqooUsxKRD2/psd1zrVDJurDa7Ayv/E21u2dIDtbp6w9Zl+he+kwRItMNhtCdzyShqtuY0V/JRmn2lZY2PsfbICRXXAbQnDveNFYz5tE2K40Qm4RWrdZ4cnaLiNJeukdYKVJCFHtZr9rdx1uVeK78Pf5o3rt4S8S1aat35eMZQunc6s4gmeXU5+wIxwXiyOtkdlL3LztSox9s="
2325

2426
matrix:
2527
include:
26-
- php: 5.6
28+
- php: 7.1
2729
env:
28-
- TEST_COVERAGE=true
30+
- DEPS=lowest
31+
- php: 7.1
32+
env:
33+
- DEPS=locked
2934
- DEPLOY_DOCS="$(if [[ $TRAVIS_BRANCH == 'master' && $TRAVIS_PULL_REQUEST == 'false' ]]; then echo -n 'true' ; else echo -n 'false' ; fi)"
3035
- PATH="$HOME/.local/bin:$PATH"
31-
- php: 7
32-
env:
33-
- CS_CHECK=true
36+
- TEST_COVERAGE=true
37+
- CHECK_CS=true
3438
- php: 7.1
39+
env:
40+
- DEPS=latest
41+
- php: nightly
42+
env:
43+
- DEPS=lowest
44+
- php: nightly
45+
env:
46+
- DEPS=locked
47+
- php: nightly
48+
env:
49+
- DEPS=latest
50+
allow_failures:
51+
- php: nightly
3552

3653
notifications:
3754
irc: "irc.freenode.org#zftalk.dev"
3855
email: false
3956

4057
before_install:
41-
- if [[ $TEST_COVERAGE != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi
42-
- composer self-update
43-
- if [[ $TEST_COVERAGE == 'true' ]]; then composer require --dev --no-update satooshi/php-coveralls:^1.0 ; fi
58+
- travis_retry composer self-update
59+
- if [[ $TEST_COVERAGE != 'true' ]]; then phpenv config-rm xdebug.ini || true ; fi
4460

4561
install:
46-
- travis_retry composer install --no-interaction
62+
- if [[ $DEPS == 'latest' ]]; then travis_retry composer update $COMPOSER_ARGS ; fi
63+
- if [[ $DEPS == 'lowest' ]]; then travis_retry composer update $COMPOSER_ARGS --prefer-lowest --prefer-stable ; fi
64+
- if [[ $TEST_COVERAGE == 'true' ]]; then travis_retry composer require --dev $COMPOSER_ARGS $COVERAGE_DEPS ; fi
65+
- travis_retry composer install $COMPOSER_ARGS
66+
- stty cols 120
67+
- COLUMNS=120 composer show
4768

4869
script:
49-
- if [[ $TEST_COVERAGE == 'true' ]]; then composer test-coverage ; fi
50-
- if [[ $TEST_COVERAGE != 'true' ]]; then composer test ; fi
51-
- if [[ $CS_CHECK == 'true' ]]; then composer cs-check ; fi
52-
- if [[ $DEPLOY_DOCS == "true" && "$TRAVIS_TEST_RESULT" == "0" ]]; then wget -O theme-installer.sh "https://raw.githubusercontent.com/zendframework/zf-mkdoc-theme/master/theme-installer.sh" ; chmod 755 theme-installer.sh ; ./theme-installer.sh ; fi
53-
54-
after_success:
55-
- if [[ $DEPLOY_DOCS == "true" ]]; then echo "Preparing to build and deploy documentation" ; ./zf-mkdoc-theme/deploy.sh ; echo "Completed deploying documentation" ; fi
70+
- if [[ $TEST_COVERAGE == 'true' ]]; then composer test-coverage ; else composer test ; fi
71+
- if [[ $CHECK_CS == 'true' ]]; then composer cs-check ; fi
72+
- if [[ $DEPLOY_DOCS == "true" && "$TRAVIS_TEST_RESULT" == "0" ]]; then travis_retry curl -sSL https://raw.githubusercontent.com/zendframework/zf-mkdoc-theme/master/theme-installer.sh | bash ; fi
5673

5774
after_script:
58-
- if [[ $TEST_COVERAGE == 'true' ]]; then composer upload-coverage ; fi
75+
- if [[ $TEST_COVERAGE == 'true' ]]; then travis_retry composer upload-coverage ; fi
76+
77+
after_success:
78+
- if [[ $DEPLOY_DOCS == "true" ]]; then ./zf-mkdoc-theme/deploy.sh ; fi

CONTRIBUTING.md

Lines changed: 13 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -36,33 +36,24 @@ For sensitive email communications, please use [our PGP key](http://framework.ze
3636

3737
## RUNNING TESTS
3838

39-
> ### Note: testing versions prior to 2.4
40-
>
41-
> This component originates with Zend Framework 2. During the lifetime of ZF2,
42-
> testing infrastructure migrated from PHPUnit 3 to PHPUnit 4. In most cases, no
43-
> changes were necessary. However, due to the migration, tests may not run on
44-
> versions < 2.4. As such, you may need to change the PHPUnit dependency if
45-
> attempting a fix on such a version.
46-
4739
To run tests:
4840

4941
- Clone the repository:
5042

5143
```console
52-
$ git clone git@github.com:zendframework/zend-servicemanager.git
53-
$ cd
44+
$ git clone git://github.com/zendframework/zend-servicemanager.git
45+
$ cd zend-servicemanager
5446
```
5547

5648
- Install dependencies via composer:
5749

5850
```console
59-
$ curl -sS https://getcomposer.org/installer | php --
60-
$ ./composer.phar install
51+
$ composer install
6152
```
6253

63-
If you don't have `curl` installed, you can also download `composer.phar` from https://getcomposer.org/
54+
If you don't have `composer` installed, please download it from https://getcomposer.org/download/
6455

65-
- Run the tests:
56+
- Run the tests using the "test" command shipped in the `composer.json`:
6657

6758
```console
6859
$ composer test
@@ -77,23 +68,22 @@ To do so:
7768

7869
## Running Coding Standards Checks
7970

80-
This component follows [PSR-1](http://www.php-fig.org/psr/psr-1/) and
81-
[PSR-2](http://www.php-fig.org/psr/psr-2/) guidelines, and ships with tooling
82-
for both checking code against standards, as well as fixing most errors.
71+
First, ensure you've installed dependencies via composer, per the previous
72+
section on running tests.
8373

84-
To run checks only:
74+
To run CS checks only:
8575

8676
```console
8777
$ composer cs-check
8878
```
8979

90-
To fix common errors:
80+
To attempt to automatically fix common CS issues:
9181

9282
```console
9383
$ composer cs-fix
9484
```
9585

96-
If you allow tooling to fix CS issues, please re-run the tests to ensure
86+
If the above fixes any CS issues, please re-run the tests to ensure
9787
they pass, and make sure you add and commit the changes after verification.
9888

9989
## Recommended Workflow for Contributions
@@ -102,12 +92,12 @@ Your first step is to establish a public repository from which we can
10292
pull your work into the master repository. We recommend using
10393
[GitHub](https://github.com), as that is where the component is already hosted.
10494

105-
1. Setup a [GitHub account](http://github.com/), if you haven't yet
106-
2. Fork the repository (http://github.com/zendframework/zend-servicemanager)
95+
1. Setup a [GitHub account](https://github.com/), if you haven't yet
96+
2. Fork the repository (https://github.com/zendframework/zend-servicemanager)
10797
3. Clone the canonical repository locally and enter it.
10898

10999
```console
110-
$ git clone git://github.com:zendframework/zend-servicemanager.git
100+
$ git clone git://github.com/zendframework/zend-servicemanager.git
111101
$ cd zend-servicemanager
112102
```
113103

composer.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,21 @@
1414
}
1515
},
1616
"require": {
17-
"php": "^5.6 || ^7.0",
17+
"php": "^7.1",
1818
"container-interop/container-interop": "^1.2",
1919
"psr/container": "^1.0",
2020
"zendframework/zend-stdlib": "^3.1"
2121
},
2222
"require-dev": {
23-
"ocramius/proxy-manager": "^1.0 || ^2.0",
24-
"phpbench/phpbench": "^0.10.0",
25-
"phpunit/phpunit": "^5.7 || ^6.0.6",
26-
"mikey179/vfsStream": "^1.6",
23+
"mikey179/vfsStream": "^1.6.4",
24+
"ocramius/proxy-manager": "^2.1.1",
25+
"phpbench/phpbench": "^0.13.0",
26+
"phpunit/phpunit": "^6.2.3",
2727
"zendframework/zend-coding-standard": "~1.0.0"
2828
},
2929
"suggest": {
30-
"ocramius/proxy-manager": "ProxyManager 1.* to handle lazy initialization of services",
31-
"zendframework/zend-stdlib": "zend-stdlib ^2.5 if you wish to use the MergeReplaceKey or MergeRemoveKey features in Config instances"
30+
"ocramius/proxy-manager": "ProxyManager ^2.1.1 to handle lazy initialization of services",
31+
"zendframework/zend-stdlib": "zend-stdlib ^2.7.7 | ^3.1 if you wish to use the MergeReplaceKey or MergeRemoveKey features in Config instances"
3232
},
3333
"minimum-stability": "dev",
3434
"prefer-stable": true,

0 commit comments

Comments
 (0)