#83 - moved test to the CommonServiceLocatorBehaviorsTrait, as it is common to ServiceManager and AbstractPluginManager

Author: Ocramius

test/CommonServiceLocatorBehaviorsTrait.php

@@ -17,6 +17,7 @@
 use Zend\ServiceManager\Exception\ContainerModificationsNotAllowedException;
 use Zend\ServiceManager\Exception\InvalidArgumentException;
 use Zend\ServiceManager\Exception\ServiceNotCreatedException;
+use Zend\ServiceManager\Exception\ServiceNotFoundException;
 use Zend\ServiceManager\Factory\FactoryInterface;
 use Zend\ServiceManager\Initializer\InitializerInterface;
 use Zend\ServiceManager\ServiceLocatorInterface;
@@ -783,4 +784,21 @@ public function testCanRetrieveParentContainerViaGetServiceLocatorWithDeprecatio
         $this->assertSame($this->creationContext, $container->getServiceLocator());
         restore_error_handler();
     }
+
+    /**
+     * @group zendframework/zend-servicemanager#83
+     */
+    public function testCrashesOnCyclicAliases()
+    {
+        $serviceManager = $this->createContainer([
+            'aliases' => [
+                'a' => 'b',
+                'b' => 'a',
+            ],
+        ]);
+
+        $this->setExpectedException(ServiceNotFoundException::class);
+
+        $serviceManager->get('b');
+    }
 }

test/ServiceManagerTest.php

@@ -237,18 +237,4 @@ public function testAliasToAnExplicitServiceShouldWork()
 
         $this->assertSame($service, $alias);
     }
-
-    public function testCrashesOnCyclicAliases()
-    {
-        $serviceManager = new ServiceManager([
-            'aliases' => [
-                'a' => 'b',
-                'b' => 'a',
-            ],
-        ]);
-
-        $this->setExpectedException(ServiceNotFoundException::class);
-
-        $serviceManager->get('b');
-    }
 }