Skip to content
This repository was archived by the owner on Feb 6, 2020. It is now read-only.

Commit 8ad06a8

Browse files
OcramiusOcramius
committed
Moved annotations to class level (less redundancy)
1 parent 45ce3e2 commit 8ad06a8

File tree

3 files changed

+15
-107
lines changed

3 files changed

+15
-107
lines changed

‎benchmarks/FetchCachedServicesBench.php

Lines changed: 5 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@
77
use PhpBench\Benchmark\Metadata\Annotations\Warmup;
88
use Zend\ServiceManager\ServiceManager;
99

10+
/**
11+
* @Revs(1000)
12+
* @Iterations(20)
13+
* @Warmup(2)
14+
*/
1015
class FetchCachedServicesBench
1116
{
1217
/**
@@ -45,13 +50,6 @@ public function __construct()
4550
$this->sm->get('recursiveAlias2');
4651
}
4752

48-
/**
49-
* Fetch the factory services
50-
*
51-
* @Revs(1000)
52-
* @Iterations(20)
53-
* @Warmup(2)
54-
*/
5553
public function benchFetchFactory1()
5654
{
5755
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -60,11 +58,6 @@ public function benchFetchFactory1()
6058
$sm->get('factory1');
6159
}
6260

63-
/**
64-
* @Revs(1000)
65-
* @Iterations(20)
66-
* @Warmup(2)
67-
*/
6861
public function benchFetchInvokable1()
6962
{
7063
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -73,11 +66,6 @@ public function benchFetchInvokable1()
7366
$sm->get('invokable1');
7467
}
7568

76-
/**
77-
* @Revs(1000)
78-
* @Iterations(20)
79-
* @Warmup(2)
80-
*/
8169
public function benchFetchService1()
8270
{
8371
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -86,11 +74,6 @@ public function benchFetchService1()
8674
$sm->get('service1');
8775
}
8876

89-
/**
90-
* @Revs(1000)
91-
* @Iterations(20)
92-
* @Warmup(2)
93-
*/
9477
public function benchFetchAlias1()
9578
{
9679
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -99,11 +82,6 @@ public function benchFetchAlias1()
9982
$sm->get('alias1');
10083
}
10184

102-
/**
103-
* @Revs(1000)
104-
* @Iterations(20)
105-
* @Warmup(2)
106-
*/
10785
public function benchFetchRecursiveAlias1()
10886
{
10987
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -112,11 +90,6 @@ public function benchFetchRecursiveAlias1()
11290
$sm->get('recursiveAlias1');
11391
}
11492

115-
/**
116-
* @Revs(1000)
117-
* @Iterations(20)
118-
* @Warmup(2)
119-
*/
12093
public function benchFetchRecursiveAlias2()
12194
{
12295
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -125,11 +98,6 @@ public function benchFetchRecursiveAlias2()
12598
$sm->get('recursiveAlias2');
12699
}
127100

128-
/**
129-
* @Revs(1000)
130-
* @Iterations(20)
131-
* @Warmup(2)
132-
*/
133101
public function benchFetchAbstractFactoryService()
134102
{
135103
// @todo @link https://github.com/phpbench/phpbench/issues/304

‎benchmarks/FetchNewServiceManagerBench.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@
77
use PhpBench\Benchmark\Metadata\Annotations\Warmup;
88
use Zend\ServiceManager\ServiceManager;
99

10+
/**
11+
* @Revs(100)
12+
* @Iterations(20)
13+
* @Warmup(2)
14+
*/
1015
class FetchNewServiceManagerBench
1116
{
1217
const NUM_SERVICES = 1000;
@@ -39,11 +44,6 @@ public function __construct()
3944
$this->config = $config;
4045
}
4146

42-
/**
43-
* @Revs(100)
44-
* @Iterations(20)
45-
* @Warmup(2)
46-
*/
4747
public function benchFetchServiceManagerCreation()
4848
{
4949
new ServiceManager($this->config);

‎benchmarks/FetchNewServicesBench.php

Lines changed: 5 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@
77
use PhpBench\Benchmark\Metadata\Annotations\Warmup;
88
use Zend\ServiceManager\ServiceManager;
99

10+
/**
11+
* @Revs(1000)
12+
* @Iterations(10)
13+
* @Warmup(2)
14+
*/
1015
class FetchNewServicesBench
1116
{
1217
/**
@@ -37,11 +42,6 @@ public function __construct()
3742
]);
3843
}
3944

40-
/**
41-
* @Revs(1000)
42-
* @Iterations(10)
43-
* @Warmup(2)
44-
*/
4545
public function benchFetchFactory1()
4646
{
4747
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -50,11 +50,6 @@ public function benchFetchFactory1()
5050
$sm->get('factory1');
5151
}
5252

53-
/**
54-
* @Revs(1000)
55-
* @Iterations(10)
56-
* @Warmup(2)
57-
*/
5853
public function benchBuildFactory1()
5954
{
6055
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -63,11 +58,6 @@ public function benchBuildFactory1()
6358
$sm->build('factory1');
6459
}
6560

66-
/**
67-
* @Revs(1000)
68-
* @Iterations(10)
69-
* @Warmup(2)
70-
*/
7161
public function benchFetchInvokable1()
7262
{
7363
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -76,11 +66,6 @@ public function benchFetchInvokable1()
7666
$sm->get('invokable1');
7767
}
7868

79-
/**
80-
* @Revs(1000)
81-
* @Iterations(10)
82-
* @Warmup(2)
83-
*/
8469
public function benchBuildInvokable1()
8570
{
8671
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -89,11 +74,6 @@ public function benchBuildInvokable1()
8974
$sm->build('invokable1');
9075
}
9176

92-
/**
93-
* @Revs(1000)
94-
* @Iterations(10)
95-
* @Warmup(2)
96-
*/
9777
public function benchFetchService1()
9878
{
9979
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -102,11 +82,6 @@ public function benchFetchService1()
10282
$sm->get('service1');
10383
}
10484

105-
/**
106-
* @Revs(1000)
107-
* @Iterations(10)
108-
* @Warmup(2)
109-
*/
11085
public function benchFetchFactoryAlias1()
11186
{
11287
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -115,11 +90,6 @@ public function benchFetchFactoryAlias1()
11590
$sm->build('factoryAlias1');
11691
}
11792

118-
/**
119-
* @Revs(1000)
120-
* @Iterations(10)
121-
* @Warmup(2)
122-
*/
12393
public function benchBuildFactoryAlias1()
12494
{
12595
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -128,11 +98,6 @@ public function benchBuildFactoryAlias1()
12898
$sm->build('factoryAlias1');
12999
}
130100

131-
/**
132-
* @Revs(1000)
133-
* @Iterations(10)
134-
* @Warmup(2)
135-
*/
136101
public function benchFetchRecursiveFactoryAlias1()
137102
{
138103
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -141,11 +106,6 @@ public function benchFetchRecursiveFactoryAlias1()
141106
$sm->build('recursiveFactoryAlias1');
142107
}
143108

144-
/**
145-
* @Revs(1000)
146-
* @Iterations(10)
147-
* @Warmup(2)
148-
*/
149109
public function benchBuildRecursiveFactoryAlias1()
150110
{
151111
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -154,11 +114,6 @@ public function benchBuildRecursiveFactoryAlias1()
154114
$sm->build('recursiveFactoryAlias1');
155115
}
156116

157-
/**
158-
* @Revs(1000)
159-
* @Iterations(10)
160-
* @Warmup(2)
161-
*/
162117
public function benchFetchRecursiveFactoryAlias2()
163118
{
164119
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -167,11 +122,6 @@ public function benchFetchRecursiveFactoryAlias2()
167122
$sm->build('recursiveFactoryAlias2');
168123
}
169124

170-
/**
171-
* @Revs(1000)
172-
* @Iterations(10)
173-
* @Warmup(2)
174-
*/
175125
public function benchBuildRecursiveFactoryAlias2()
176126
{
177127
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -180,11 +130,6 @@ public function benchBuildRecursiveFactoryAlias2()
180130
$sm->build('recursiveFactoryAlias2');
181131
}
182132

183-
/**
184-
* @Revs(1000)
185-
* @Iterations(10)
186-
* @Warmup(2)
187-
*/
188133
public function benchFetchAbstractFactoryFoo()
189134
{
190135
// @todo @link https://github.com/phpbench/phpbench/issues/304
@@ -193,11 +138,6 @@ public function benchFetchAbstractFactoryFoo()
193138
$sm->get('foo');
194139
}
195140

196-
/**
197-
* @Revs(1000)
198-
* @Iterations(10)
199-
* @Warmup(2)
200-
*/
201141
public function benchBuildAbstractFactoryFoo()
202142
{
203143
// @todo @link https://github.com/phpbench/phpbench/issues/304

0 commit comments

Comments
 (0)