Fixed introduced bc break by adding Named Constructor for CMNAException.

Author: fhein

src/Exception/ContainerModificationsNotAllowedException.php

@@ -14,10 +14,9 @@
  */
 class ContainerModificationsNotAllowedException extends DomainException implements ExceptionInterface
 {
-
-    public function __construct($service)
+    public static function fromExistingService($service)
     {
-        parent::__construct(sprintf(
+        return new self(sprintf(
             'The container does not allow to replace/update a service'
             . ' with existing instances; the following '
             . 'already exist in the container: %s',

src/ServiceManager.php

@@ -413,7 +413,7 @@ public function setAlias($alias, $target)
             $this->mapAliasToTarget($alias, $target);
             return;
         }
-        throw new ContainerModificationsNotAllowedException($alias);
+        throw ContainerModificationsNotAllowedException::fromExistingService($alias);
     }
 
     /**
@@ -429,7 +429,7 @@ public function setInvokableClass($name, $class = null)
             $this->createAliasesAndFactoriesForInvokables([$name => $class ?? $name]);
             return;
         }
-        throw new ContainerModificationsNotAllowedException($name);
+        throw ContainerModificationsNotAllowedException::fromExistingService($name);
     }
 
     /**
@@ -445,7 +445,7 @@ public function setFactory($name, $factory)
             $this->factories[$name] = $factory;
             return;
         }
-        throw new ContainerModificationsNotAllowedException($name);
+        throw ContainerModificationsNotAllowedException::fromExistingService($name);
     }
 
     /**
@@ -504,7 +504,7 @@ public function setService($name, $service)
             $this->services[$name] = $service;
             return;
         }
-        throw new ContainerModificationsNotAllowedException($name);
+        throw ContainerModificationsNotAllowedException::fromExistingService($name);
     }
 
     /**
@@ -519,7 +519,7 @@ public function setShared($name, $flag)
             $this->shared[$name] = (bool) $flag;
             return;
         }
-        throw new ContainerModificationsNotAllowedException($name);
+        throw ContainerModificationsNotAllowedException::fromExistingService($name);
     }
 
     /**
@@ -798,7 +798,7 @@ private function validateServiceNames(array $config)
                 if (! isset($this->services[$service]) || $this->allowOverride) {
                     continue;
                 }
-                throw new ContainerModificationsNotAllowedException($service);
+                throw ContainerModificationsNotAllowedException::fromExistingService($service);
             }
         }
 
@@ -807,7 +807,7 @@ private function validateServiceNames(array $config)
                 if (! isset($this->services[$service]) || $this->allowOverride) {
                     continue;
                 }
-                throw new ContainerModificationsNotAllowedException($service);
+                throw ContainerModificationsNotAllowedException::fromExistingService($service);
             }
         }
 
@@ -816,7 +816,7 @@ private function validateServiceNames(array $config)
                 if (! isset($this->services[$service]) || $this->allowOverride) {
                     continue;
                 }
-                throw new ContainerModificationsNotAllowedException($service);
+                throw ContainerModificationsNotAllowedException::fromExistingService($service);
             }
         }
 
@@ -825,7 +825,7 @@ private function validateServiceNames(array $config)
                 if (! isset($this->services[$service]) || $this->allowOverride) {
                     continue;
                 }
-                throw new ContainerModificationsNotAllowedException($service);
+                throw ContainerModificationsNotAllowedException::fromExistingService($service);
             }
         }
 
@@ -834,7 +834,7 @@ private function validateServiceNames(array $config)
                 if (! isset($this->services[$service]) || $this->allowOverride) {
                     continue;
                 }
-                throw new ContainerModificationsNotAllowedException($service);
+                throw ContainerModificationsNotAllowedException::fromExistingService($service);
             }
         }
 
@@ -843,7 +843,7 @@ private function validateServiceNames(array $config)
                 if (! isset($this->services[$service]) || $this->allowOverride) {
                     continue;
                 }
-                throw new ContainerModificationsNotAllowedException($service);
+                throw ContainerModificationsNotAllowedException::fromExistingService($service);
             }
         }
 
@@ -852,7 +852,7 @@ private function validateServiceNames(array $config)
                 if (! isset($this->services[$service]) || $this->allowOverride) {
                     continue;
                 }
-                throw new ContainerModificationsNotAllowedException($service);
+                throw ContainerModificationsNotAllowedException::fromExistingService($service);
             }
         }
     }