Added more array checking and slimlined argument retrieval (thanks @Ocramius)

Author: GeeH

src/AbstractFactory/ConfigAbstractFactory.php

@@ -27,7 +27,9 @@ public function canCreate(\Interop\Container\ContainerInterface $container, $req
         $config = $container->get('config');
         $dependencies = $config[self::class];
 
-        return array_key_exists($requestedName, $dependencies);
+        return is_array($dependencies) && array_key_exists($requestedName, $dependencies) && is_array(
+            $dependencies[$requestedName]
+        );
     }
 
     /**
@@ -37,16 +39,7 @@ public function __invoke(\Interop\Container\ContainerInterface $container, $requ
     {
         $config = $container->get('config');
         $dependencies = $config[self::class][$requestedName];
-
-        // class has no dependencies, just create it and return
-        if (empty($dependencies)) {
-            return new $requestedName();
-        }
-
-        $arguments = [];
-        foreach ($dependencies as $dependency) {
-            $arguments[] = $container->get($dependency);
-        }
+        $arguments = array_map([$container, 'get'], $dependencies);
 
         return new $requestedName(...$arguments);
     }

test/AbstractFactory/ConfigAbstractFactoryTest.php

@@ -21,12 +21,31 @@
 class ConfigAbstractFactoryTest extends \PHPUnit_Framework_TestCase
 {
 
-    public function testCanCreateShortCircuits()
+    public function testCanCreateReturnsFalseIfDependencyNotArrays()
     {
         $abstractFactory = new ConfigAbstractFactory();
         $serviceManager = new ServiceManager();
+        $serviceManager->setService(
+            'config',
+            [
+                ConfigAbstractFactory::class => 'Blancmange',
+            ]
+        );
+
+        self::assertFalse($abstractFactory->canCreate($serviceManager, InvokableObject::class));
+
+        $serviceManager->setAllowOverride(true);g
+        $serviceManager->setService(
+            'config',
+            [
+                ConfigAbstractFactory::class => [
+                    InvokableObject::class => 42,
+                ]
+            ]
+        );
+
+        self::assertFalse($abstractFactory->canCreate($serviceManager, InvokableObject::class));
 
-        self::assertFalse($abstractFactory->canCreate($serviceManager, 'OcramiusSucks'));
     }
 
     public function testCanCreate()