Skip to content
This repository was archived by the owner on Feb 6, 2020. It is now read-only.

Commit 9dec814

Browse files
author
fhein
committed
Tweaks as requested by webimpress.
1 parent ea1dc90 commit 9dec814

File tree

4 files changed

+17
-24
lines changed

4 files changed

+17
-24
lines changed

src/Exception/CyclicAliasException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
class CyclicAliasException extends InvalidArgumentException
2121
{
2222
/**
23-
* @param string conflicting alias key
23+
* @param string $alias conflicting alias key
2424
* @param string[] $aliases map of referenced services, indexed by alias name (string)
2525
*
2626
* @return self

src/Exception/InvalidArgumentException.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public static function fromInvalidInitializer($initializer)
2323
. '(or valid class name or function name resolving to) "%s", '
2424
. 'but "%s" was received',
2525
InitializerInterface::class,
26-
(is_object($initializer) ? get_class($initializer) : gettype($initializer))
26+
is_object($initializer) ? get_class($initializer) : gettype($initializer)
2727
));
2828
}
2929

@@ -33,7 +33,7 @@ public static function fromInvalidAbstractFactory($abstractFactory)
3333
'An invalid abstract factory was registered. Expected an instance of or a '
3434
. 'valid class name resolving to an implementation of "%s", but "%s" was received.',
3535
AbstractFactoryInterface::class,
36-
(is_object($abstractFactory) ? get_class($abstractFactory) : gettype($abstractFactory))
36+
is_object($abstractFactory) ? get_class($abstractFactory) : gettype($abstractFactory)
3737
));
3838
}
3939
}

src/ServiceManager.php

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,18 @@
2121
use Zend\ServiceManager\Exception\ServiceNotCreatedException;
2222
use Zend\ServiceManager\Exception\ServiceNotFoundException;
2323

24-
use function \array_merge_recursive;
25-
use function \class_exists;
26-
use function \get_class;
27-
use function \gettype;
28-
use function \is_callable;
29-
use function \is_object;
30-
use function \is_string;
31-
use function \spl_autoload_register;
32-
use function \spl_object_hash;
33-
use function \sprintf;
34-
use function \trigger_error;
35-
use function \in_array;
24+
use function array_merge_recursive;
25+
use function class_exists;
26+
use function get_class;
27+
use function gettype;
28+
use function is_callable;
29+
use function is_object;
30+
use function is_string;
31+
use function spl_autoload_register;
32+
use function spl_object_hash;
33+
use function sprintf;
34+
use function trigger_error;
35+
use function in_array;
3636

3737
/**
3838
* Service Manager.
@@ -526,8 +526,6 @@ public function setShared($name, $flag)
526526
* Instantiate initializers for to avoid checks during service construction.
527527
*
528528
* @param string[]|Initializer\InitializerInterface[]|callable[] $initializers
529-
*
530-
* @return void
531529
*/
532530
private function resolveInitializers(array $initializers)
533531
{

test/Exception/CyclicAliasExceptionTest.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,9 @@ class CyclicAliasExceptionTest extends TestCase
1919
/**
2020
* @dataProvider cyclicAliasProvider
2121
*
22-
* @param string conflicting alias key
22+
* @param string $alias, conflicting alias key
2323
* @param string[] $aliases
2424
* @param string $expectedMessage
25-
*
26-
* @return void
2725
*/
2826
public function testFromCyclicAlias($alias, array $aliases, $expectedMessage)
2927
{
@@ -40,8 +38,7 @@ public function testFromCyclicAlias($alias, array $aliases, $expectedMessage)
4038
*/
4139
public function cyclicAliasProvider()
4240
{
43-
return
44-
[
41+
return [
4542
[
4643
'a',
4744
[
@@ -115,8 +112,6 @@ public function cyclicAliasProvider()
115112
*
116113
* @param string[] $aliases
117114
* @param string $expectedMessage
118-
*
119-
* @return void
120115
*/
121116
public function testFromAliasesMap(array $aliases, $expectedMessage)
122117
{

0 commit comments

Comments
 (0)