Skip to content
This repository was archived by the owner on Feb 6, 2020. It is now read-only.

Commit c129c03

Browse files
committed
Merge branch 'hotfix/233-parameter-type-hints' into develop
Forward port #233 Also brings in changes specific to develop branch.
2 parents 84c1dda + 331ce27 commit c129c03

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@ All notable changes to this project will be documented in this file, in reverse
5757
with default values to their default values if no matching type is found in
5858
the container.
5959

60+
- [#233](https://github.com/zendframework/zend-servicemanager/pull/233) fixes a
61+
number of parameter annotations to reflect the actual types used.
62+
6063
## 3.3.1 - 2017-11-27
6164

6265
### Added

src/AbstractFactory/ReflectionBasedAbstractFactory.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ public function canCreate(ContainerInterface $container, $requestedName)
154154
private function resolveParameterWithoutConfigService(ContainerInterface $container, $requestedName)
155155
{
156156
/**
157-
* @param ReflectionClass $parameter
157+
* @param ReflectionParameter $parameter
158158
* @return mixed
159159
* @throws ServiceNotFoundException If type-hinted parameter cannot be
160160
* resolved to a service in the container.
@@ -177,7 +177,7 @@ private function resolveParameterWithoutConfigService(ContainerInterface $contai
177177
private function resolveParameterWithConfigService(ContainerInterface $container, $requestedName)
178178
{
179179
/**
180-
* @param ReflectionClass $parameter
180+
* @param ReflectionParameter $parameter
181181
* @return mixed
182182
* @throws ServiceNotFoundException If type-hinted parameter cannot be
183183
* resolved to a service in the container.
@@ -193,7 +193,7 @@ private function resolveParameterWithConfigService(ContainerInterface $container
193193
/**
194194
* Logic common to all parameter resolution.
195195
*
196-
* @param ReflectionClass $parameter
196+
* @param ReflectionParameter $parameter
197197
* @param ContainerInterface $container
198198
* @param string $requestedName
199199
* @return mixed

src/ServiceManager.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -923,8 +923,7 @@ private function mapAliasesToTargets()
923923
/**
924924
* Instantiate abstract factories in order to avoid checks during service construction.
925925
*
926-
* @param string[]|Factory\AbstractFactoryInterface[] $abstractFactories
927-
*
926+
* @param string|Factory\AbstractFactoryInterface $abstractFactories
928927
* @return void
929928
*/
930929
private function resolveAbstractFactoryInstance($abstractFactory)

0 commit comments

Comments
 (0)