Incorporate feedback from review

- Use private visibility for `$container` property
- Remove `setContainer()` method; updated tests to create a new
  `ConfigDumper` instance using the mock container, instead of using
  setter injection.
- Updated copyrights on licence docblocks of changed files.

Author: weierophinney

src/Tool/ConfigDumper.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @link      http://github.com/zendframework/zend-servicemanager for the canonical source repository
- * @copyright Copyright (c) 2016 Zend Technologies USA Inc. (http://www.zend.com)
+ * @copyright Copyright (c) 2016-2017 Zend Technologies USA Inc. (http://www.zend.com)
  * @license   http://framework.zend.com/license/new-bsd New BSD License
  */
 
@@ -29,7 +29,7 @@ class ConfigDumper
     /**
      * @var ContainerInterface
      */
-    protected $container;
+    private $container;
 
     /**
      * @param ContainerInterface $container
@@ -39,14 +39,6 @@ public function __construct(ContainerInterface $container = null)
         $this->container = $container;
     }
 
-    /**
-     * @param ContainerInterface $container
-     */
-    public function setContainer(ContainerInterface $container)
-    {
-        $this->container = $container;
-    }
-
     /**
      * @param array $config
      * @param string $className

src/Tool/ConfigDumperCommand.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @link      http://github.com/zendframework/zend-servicemanager for the canonical source repository
- * @copyright Copyright (c) 2016 Zend Technologies USA Inc. (http://www.zend.com)
+ * @copyright Copyright (c) 2016-2017 Zend Technologies USA Inc. (http://www.zend.com)
  * @license   http://framework.zend.com/license/new-bsd New BSD License
  */
 

test/TestAsset/ObjectWithObjectScalarDependency.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @link      http://github.com/zendframework/zend-servicemanager for the canonical source repository
- * @copyright Copyright (c) 2016 Zend Technologies USA Inc. (http://www.zend.com)
+ * @copyright Copyright (c) 2017 Zend Technologies USA Inc. (http://www.zend.com)
  * @license   http://framework.zend.com/license/new-bsd New BSD License
  */
 

test/Tool/ConfigDumperCommandTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @link      http://github.com/zendframework/zend-servicemanager for the canonical source repository
- * @copyright Copyright (c) 2016 Zend Technologies USA Inc. (http://www.zend.com)
+ * @copyright Copyright (c) 2016-2017 Zend Technologies USA Inc. (http://www.zend.com)
  * @license   http://framework.zend.com/license/new-bsd New BSD License
  */
 
@@ -63,8 +63,8 @@ public function helpArguments()
     public function ignoreUnresolvedArguments()
     {
         return [
-            'short'   => ['-i'],
-            'long'    => ['--ignore-unresolved'],
+            'short' => ['-i'],
+            'long'  => ['--ignore-unresolved'],
         ];
     }
 

test/Tool/ConfigDumperTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @link      http://github.com/zendframework/zend-servicemanager for the canonical source repository
- * @copyright Copyright (c) 2016 Zend Technologies USA Inc. (http://www.zend.com)
+ * @copyright Copyright (c) 2016-2017 Zend Technologies USA Inc. (http://www.zend.com)
  * @license   http://framework.zend.com/license/new-bsd New BSD License
  */
 
@@ -114,8 +114,10 @@ public function testCreateDependencyConfigWithContainerAndNoServiceWithoutTypeHi
         $container->has(ObjectWithScalarDependency::class)
             ->shouldBeCalled()
             ->willReturn(false);
-        $this->dumper->setContainer($container->reveal());
-        $config = $this->dumper->createDependencyConfig(
+
+        $dumper = new ConfigDumper($container->reveal());
+
+        $config = $dumper->createDependencyConfig(
             [ConfigAbstractFactory::class => []],
             ObjectWithScalarDependency::class
         );
@@ -127,11 +129,14 @@ public function testCreateDependencyConfigWithContainerWithoutTypeHintedParamete
         $container->has(ObjectWithScalarDependency::class)
             ->shouldBeCalled()
             ->willReturn(true);
-        $this->dumper->setContainer($container->reveal());
-        $config = $this->dumper->createDependencyConfig(
+
+        $dumper = new ConfigDumper($container->reveal());
+
+        $config = $dumper->createDependencyConfig(
             [ConfigAbstractFactory::class => []],
             ObjectWithObjectScalarDependency::class
         );
+
         self::assertEquals(
             [
                 ConfigAbstractFactory::class => [