Skip to content
This repository was archived by the owner on Feb 6, 2020. It is now read-only.

Commit cb63391

Browse files
committed
Add test comments
1 parent e302410 commit cb63391

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

test/ServiceManagerTest.php

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -104,20 +104,22 @@ function ($container, $name, $callback) {
104104
$this->assertEquals('bar', $instance->foo);
105105
}
106106

107-
public function cacheProvider()
107+
public function shareProvider()
108108
{
109+
// @codingStandardsIgnoreStart
109110
return [
110-
[true, true, true],
111-
[true, false, false],
112-
[false, false, false],
113-
[false, true, true]
111+
[true, true, true], // [shared by default, service is explicitly shared => should be shared]
112+
[true, false, false], // [shared by default, service is explicitly NOT shared => should NOT be shared]
113+
[false, false, false], // [NOT shared by default, service is explicitly NOT shared => should NOT be shared]
114+
[false, true, true] // [NOT shared by default, service is explicitly shared => should be shared]
114115
];
116+
// @codingStandardsIgnoreEnd
115117
}
116118

117119
/**
118-
* @dataProvider cacheProvider
120+
* @dataProvider shareProvider
119121
*/
120-
public function testCacheability($sharedByDefault, $serviceShared, $shouldBeSameInstance)
122+
public function testShareability($sharedByDefault, $serviceShared, $shouldBeSameInstance)
121123
{
122124
$serviceManager = new ServiceManager([
123125
'shared_by_default' => $sharedByDefault,

0 commit comments

Comments
 (0)