Removes extraneous whitespace and adds array typehint

Also updates test exception message expectations to match changes in
class.

Author: weierophinney

src/Exception/CyclicAliasException.php

@@ -22,10 +22,9 @@ class CyclicAliasException extends InvalidArgumentException
     /**
      * @param string   $alias conflicting alias key
      * @param string[] $aliases map of referenced services, indexed by alias name (string)
-     *
      * @return self
      */
-    public static function fromCyclicAlias($alias, $aliases)
+    public static function fromCyclicAlias($alias, array $aliases)
     {
         $cycle = $alias;
         $cursor = $alias;
@@ -36,14 +35,13 @@ public static function fromCyclicAlias($alias, $aliases)
         $cycle .= ' -> ' . $alias . "\n";
 
         return new self(sprintf(
-            "A cycle was detected within the aliases defintions:\n%s",
+            "A cycle was detected within the aliases definitions:\n%s",
             $cycle
         ));
     }
 
     /**
      * @param string[] $aliases map of referenced services, indexed by alias name (string)
-     *
      * @return self
      */
     public static function fromAliasesMap(array $aliases)
@@ -75,7 +73,6 @@ function ($alias) use ($aliases) {
      *
      * @param string[] $aliases
      * @param string   $alias
-     *
      * @return array|null
      */
     private static function getCycleFor(array $aliases, $alias)
@@ -89,7 +86,6 @@ private static function getCycleFor(array $aliases, $alias)
             }
 
             $cycleCandidate[$targetName] = true;
-
             $targetName = $aliases[$targetName];
         }
 
@@ -98,7 +94,6 @@ private static function getCycleFor(array $aliases, $alias)
 
     /**
      * @param string[] $aliases
-     *
      * @return string
      */
     private static function printReferencesMap(array $aliases)
@@ -114,7 +109,6 @@ private static function printReferencesMap(array $aliases)
 
     /**
      * @param string[][] $detectedCycles
-     *
      * @return string
      */
     private static function printCycles(array $detectedCycles)
@@ -124,7 +118,6 @@ private static function printCycles(array $detectedCycles)
 
     /**
      * @param string[] $detectedCycle
-     *
      * @return string
      */
     private static function printCycle(array $detectedCycle)
@@ -145,7 +138,6 @@ function ($cycle) {
 
     /**
      * @param bool[][] $detectedCycles
-     *
      * @return bool[][] de-duplicated
      */
     private static function deDuplicateDetectedCycles(array $detectedCycles)

test/Exception/CyclicAliasExceptionTest.php

@@ -44,7 +44,7 @@ public function cyclicAliasProvider()
                 [
                     'a' => 'a',
                 ],
-                "A cycle was detected within the aliases defintions:\n"
+                "A cycle was detected within the aliases definitions:\n"
                 . "a -> a\n",
             ],
             [
@@ -53,7 +53,7 @@ public function cyclicAliasProvider()
                     'a' => 'b',
                     'b' => 'a'
                 ],
-                "A cycle was detected within the aliases defintions:\n"
+                "A cycle was detected within the aliases definitions:\n"
                 . "a -> b -> a\n",
             ],
             [
@@ -62,7 +62,7 @@ public function cyclicAliasProvider()
                     'a' => 'b',
                     'b' => 'a'
                 ],
-                "A cycle was detected within the aliases defintions:\n"
+                "A cycle was detected within the aliases definitions:\n"
                 . "b -> a -> b\n",
             ],
             [
@@ -71,7 +71,7 @@ public function cyclicAliasProvider()
                     'a' => 'b',
                     'b' => 'a',
                 ],
-                "A cycle was detected within the aliases defintions:\n"
+                "A cycle was detected within the aliases definitions:\n"
                 . "b -> a -> b\n",
             ],
             [
@@ -81,7 +81,7 @@ public function cyclicAliasProvider()
                     'b' => 'c',
                     'c' => 'a',
                 ],
-                "A cycle was detected within the aliases defintions:\n"
+                "A cycle was detected within the aliases definitions:\n"
                 . "a -> b -> c -> a\n",
             ],
             [
@@ -91,7 +91,7 @@ public function cyclicAliasProvider()
                     'b' => 'c',
                     'c' => 'a',
                 ],
-                "A cycle was detected within the aliases defintions:\n"
+                "A cycle was detected within the aliases definitions:\n"
                 . "b -> c -> a -> b\n",
             ],
             [
@@ -101,7 +101,7 @@ public function cyclicAliasProvider()
                     'b' => 'c',
                     'c' => 'a',
                 ],
-                "A cycle was detected within the aliases defintions:\n"
+                "A cycle was detected within the aliases definitions:\n"
                 . "c -> a -> b -> c\n",
             ],
         ];