CS fixes

- Switches to phpcs for CS checks.
- Fixes several CS issues, including long lines.

Author: weierophinney

.php_cs

@@ -19,8 +19,8 @@
     },
     "require-dev": {
         "phpunit/phpunit": "~4.6",
-        "fabpot/php-cs-fixer": "1.7.*",
-        "ocramius/proxy-manager": "~1.0"
+        "ocramius/proxy-manager": "~1.0",
+        "squizlabs/php_codesniffer": "^2.0@dev"
     },
     "suggest": {
         "ocramius/proxy-manager": "ProxyManager 1.* to handle lazy initialization of services"

composer.json

@@ -0,0 +1,21 @@
+<?xml version="1.0"?>
+<ruleset name="Zend Framework coding standard">
+    <description>Zend Framework coding standard</description>
+
+    <!-- display progress -->
+    <arg value="p"/>
+    <arg name="colors"/>
+
+    <!-- inherit rules from: -->
+    <rule ref="PSR2"/>
+    <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
+    <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace">
+        <properties>
+            <property name="ignoreBlankLines" value="false"/>
+        </properties>
+    </rule>
+
+    <!-- Paths to check -->
+    <file>src</file>
+    <file>test</file>
+</ruleset>

phpcs.xml

@@ -23,7 +23,8 @@ interface PluginManagerInterface extends ServiceLocatorInterface
      *
      * @param  object $instance
      * @return void
-     * @throws InvalidServiceException If created instance does not respect the constraint on type imposed by the plugin manager
+     * @throws InvalidServiceException If created instance does not respect the
+     *     constraint on type imposed by the plugin manager
      */
     public function validate($instance);
 }

src/PluginManagerInterface.php

@@ -185,12 +185,17 @@ public function has($name, $checkAbstractFactories = false)
     protected function configure(array $config)
     {
         $this->factories       = (isset($config['factories']) ? $config['factories'] : []) + $this->factories;
-        $this->delegators      = array_merge_recursive($this->delegators, isset($config['delegators']) ? $config['delegators'] : []);
+        $this->delegators      = array_merge_recursive($this->delegators, isset($config['delegators'])
+            ? $config['delegators']
+            : []);
         $this->shared          = (isset($config['shared']) ? $config['shared'] : []) + $this->shared;
         $this->aliases         = (isset($config['aliases']) ? $config['aliases'] : []) + $this->aliases;
-        $this->sharedByDefault = isset($config['shared_by_default']) ? $config['shared_by_default'] : $this->sharedByDefault;
+        $this->sharedByDefault = isset($config['shared_by_default'])
+            ? $config['shared_by_default']
+            : $this->sharedByDefault;
 
-        // For abstract factories and initializers, we always directly instantiate them to avoid checks during construction
+        // For abstract factories and initializers, we always directly
+        // instantiate them to avoid checks during construction
         if (isset($config['abstract_factories'])) {
             foreach ($config['abstract_factories'] as $abstractFactory) {
                 if (is_string($abstractFactory)) {
@@ -297,7 +302,7 @@ private function createDelegatorFromName($name, array $options = [])
             return $factory($this->creationContext, $name, $options);
         };
 
-        for ($i = 0 ; $i < $delegatorsCount ; ++$i) {
+        for ($i = 0; $i < $delegatorsCount; ++$i) {
             $delegatorFactory = $this->delegators[$name][$i];
 
             if (is_string($delegatorFactory)) {

src/ServiceManager.php

@@ -21,4 +21,4 @@ public function __invoke(ContainerInterface $container, $requestedName, array $o
     {
         throw new \RuntimeException('There is an error');
     }
-}
+}