ReflectionBasedAbstractFactory should not be expected to instantiate private constructors

Author: asgrim

src/AbstractFactory/ReflectionBasedAbstractFactory.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @link      http://github.com/zendframework/zend-servicemanager for the canonical source repository
- * @copyright Copyright (c) 2016 Zend Technologies USA Inc. (http://www.zend.com)
+ * @copyright Copyright (c) 2018 Zend Technologies USA Inc. (http://www.zend.com)
  * @license   http://framework.zend.com/license/new-bsd New BSD License
  */
 
@@ -131,10 +131,27 @@ public function __invoke(ContainerInterface $container, $requestedName, array $o
 
     /**
      * {@inheritDoc}
+     * @throws \ReflectionException
      */
     public function canCreate(ContainerInterface $container, $requestedName)
     {
-        return class_exists($requestedName);
+        return class_exists($requestedName) && $this->canCallConstructor($requestedName);
+    }
+
+    /**
+     * @param string $requestedName
+     * @return bool
+     * @throws \ReflectionException
+     */
+    private function canCallConstructor(string $requestedName) : bool
+    {
+        $constructor = (new ReflectionClass($requestedName))->getConstructor();
+
+        if ($constructor === null) {
+            return true;
+        }
+
+        return $constructor->isPublic();
     }
 
     /**

test/AbstractFactory/ReflectionBasedAbstractFactoryTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @link      http://github.com/zendframework/zend-servicemanager for the canonical source repository
- * @copyright Copyright (c) 2016 Zend Technologies USA Inc. (http://www.zend.com)
+ * @copyright Copyright (c) 2018 Zend Technologies USA Inc. (http://www.zend.com)
  * @license   http://framework.zend.com/license/new-bsd New BSD License
  */
 
@@ -15,6 +15,8 @@
 
 class ReflectionBasedAbstractFactoryTest extends TestCase
 {
+    private $container;
+
     public function setUp()
     {
         $this->container = $this->prophesize(ContainerInterface::class);
@@ -36,6 +38,20 @@ public function testCanCreateReturnsFalseForNonClassRequestedNames($requestedNam
         $this->assertFalse($factory->canCreate($this->container->reveal(), $requestedName));
     }
 
+    /**
+     * @throws \ReflectionException
+     */
+    public function testCanCreateReturnsFalseWhenConstructorIsPrivate() : void
+    {
+        self::assertFalse(
+            (new ReflectionBasedAbstractFactory())->canCreate(
+                $this->container->reveal(),
+                TestAsset\ClassWithPrivateConstructor::class
+            ),
+            'ReflectionBasedAbstractFactory should not be able to instantiate a class with a private constructor'
+        );
+    }
+
     public function testFactoryInstantiatesClassDirectlyIfItHasNoConstructor()
     {
         $factory = new ReflectionBasedAbstractFactory();

test/AbstractFactory/TestAsset/ClassWithPrivateConstructor.php

@@ -0,0 +1,15 @@
+<?php
+/**
+ * @link      http://github.com/zendframework/zend-servicemanager for the canonical source repository
+ * @copyright Copyright (c) 2018 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license   http://framework.zend.com/license/new-bsd New BSD License
+ */
+
+namespace ZendTest\ServiceManager\AbstractFactory\TestAsset;
+
+class ClassWithPrivateConstructor
+{
+    private function __construct()
+    {
+    }
+}