Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

Commit 4fb83ae

Browse files
committed
Better test name
Made the new test name more specific, and assigned the test to a group based on the issue number.
1 parent 4af74c7 commit 4fb83ae

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

test/Helper/HeadScriptTest.php

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,9 @@ public function testConditionalScriptNoIE()
382382
{
383383
$this->helper->setAllowArbitraryAttributes(true);
384384
$this->helper->appendFile(
385-
'/js/foo.js', 'text/javascript', ['conditional' => '!IE']
385+
'/js/foo.js',
386+
'text/javascript',
387+
['conditional' => '!IE']
386388
);
387389
$test = $this->helper->toString();
388390

@@ -394,7 +396,9 @@ public function testConditionalScriptNoIEWidthSpace()
394396
{
395397
$this->helper->setAllowArbitraryAttributes(true);
396398
$this->helper->appendFile(
397-
'/js/foo.js', 'text/javascript', ['conditional' => '! IE']
399+
'/js/foo.js',
400+
'text/javascript',
401+
['conditional' => '! IE']
398402
);
399403
$test = $this->helper->toString();
400404

@@ -465,14 +469,19 @@ public function testNoEscapeTrue()
465469
public function testSupportsCrossOriginAttribute()
466470
{
467471
$this->helper->__invoke()->appendScript(
468-
'// some script' . PHP_EOL, 'text/javascript', ['crossorigin' => true]
472+
'// some script' . PHP_EOL,
473+
'text/javascript',
474+
['crossorigin' => true]
469475
);
470476
$test = $this->helper->__invoke()->toString();
471477

472478
$this->assertContains('crossorigin="', $test);
473479
}
474480

475-
public function testOmitsTypeAttributeIfEmptyValue()
481+
/**
482+
* @group 21
483+
*/
484+
public function testOmitsTypeAttributeIfEmptyValueAndHtml5Doctype()
476485
{
477486
$view = new \Zend\View\Renderer\PhpRenderer();
478487
$view->plugin('doctype')->setDoctype(\Zend\View\Helper\Doctype::HTML5);

0 commit comments

Comments
 (0)