Ensure all builds pass

This patch does a number of things to ensure all builds will pass on
Travis.

First, it removes the `composer.lock`, and modifies the tests to run
against latest and lowest dependencies only, with the following notes:

- When running against lowest, we need to remove zend-router, as
  composer 1.8 incorrectly flags version 3.0.1 incompatible with
  zend-mvc v2 releases, and thus installs zend-mvc 3.0.0 always. I will
  be reporting this to the composer team.

- When running against latest, we need to add
  zend-mvc-plugin-flashmessenger, zend-mvc-i18n, and zend-mvc-console so
  that tests against all helpers will pass.

Through experimentation, I found that running against the lockfile was
problematic due to some dependencies only running on PHP 7.1 and up, as
well as the various mixes in dependencies when running against different
zend-mvc versions. A lowest/latest approach should be sufficient for our
needs until we are able to bump to PHP 7.1+ and drop support for
zend-mvc v2 releases.

Additionally, this patch adds environments for the PHP 7.3 series, to
ensure we are compatible.

Author: weierophinney

.gitignore

@@ -12,5 +12,6 @@ vendor/
 zf-mkdoc-theme/
 
 clover.xml
+composer.lock
 coveralls-upload.json
 phpunit.xml

.travis.yml

@@ -11,59 +11,49 @@ env:
     - COMPOSER_PROCESS_TIMEOUT=600
     - COMPOSER_ARGS="--no-interaction"
     - COVERAGE_DEPS="php-coveralls/php-coveralls"
-    - LEGACY_DEPS="phpunit/phpunit"
-    - LATEST_DEPS="zendframework/zend-mvc-plugin-flashmessenger zendframework/zend-mvc-i18n zendframework/zend-mvc-console"
+    - LOWEST_DEPS_REMOVE="zendframework/zend-router"
+    - LATEST_DEPS_REQUIRE="zendframework/zend-mvc-plugin-flashmessenger zendframework/zend-mvc-i18n zendframework/zend-mvc-console"
 
 matrix:
   include:
     - php: 5.6
       env:
         - DEPS=lowest
-    - php: 5.6
-      env:
-        - DEPS=locked
     - php: 5.6
       env:
         - DEPS=latest
     - php: 7
       env:
         - DEPS=lowest
-    - php: 7
-      env:
-        - DEPS=locked
-        - CS_CHECK=true
-        - TEST_COVERAGE=true
     - php: 7
       env:
         - DEPS=latest
     - php: 7.1
       env:
         - DEPS=lowest
-    - php: 7.1
-      env:
-        - DEPS=locked
     - php: 7.1
       env:
         - DEPS=latest
+        - CS_CHECK=true
+        - TEST_COVERAGE=true
     - php: 7.2
       env:
         - DEPS=lowest
     - php: 7.2
       env:
-        - DEPS=locked
-    - php: 7.2
+        - DEPS=latest
+    - php: 7.3
       env:
         - DEPS=latest
 
 before_install:
   - if [[ $TEST_COVERAGE != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi
+  - if [[ $DEPS == 'lowest' ]]; then travis_retry composer remove $COMPOSER_ARGS --no-update --dev $LOWEST_DEPS_REMOVE ; fi
+  - if [[ $DEPS == 'latest' ]]; then travis_retry composer require $COMPOSER_ARGS --no-update --dev $LATEST_DEPS_REQUIRE ; fi
 
 install:
-  - travis_retry composer install $COMPOSER_ARGS --ignore-platform-reqs
-  - if [[ $TRAVIS_PHP_VERSION =~ ^5.6 ]]; then travis_retry composer update $COMPOSER_ARGS --with-dependencies $LEGACY_DEPS ; fi
-  - if [[ $DEPS == 'latest' ]]; then travis_retry composer require --dev --no-update $COMPOSER_ARGS $LATEST_DEPS ; fi
-  - if [[ $DEPS == 'latest' ]]; then travis_retry composer update $COMPOSER_ARGS ; fi
-  - if [[ $DEPS == 'lowest' ]]; then travis_retry composer update --prefer-lowest --prefer-stable $COMPOSER_ARGS ; fi
+  - if [[ $DEPS == 'lowest' ]]; then travis_retry composer update $COMPOSER_ARGS --prefer-lowest --prefer-stable ; fi
+  - if [[ $DEPS == 'latest' ]]; then travis_retry composer install ; fi
   - if [[ $TEST_COVERAGE == 'true' ]]; then travis_retry composer require --dev $COMPOSER_ARGS $COVERAGE_DEPS ; fi
   - stty cols 120 && composer show
 

composer.json

@@ -33,7 +33,7 @@
         "zendframework/zend-i18n": "^2.6",
         "zendframework/zend-log": "^2.7",
         "zendframework/zend-modulemanager": "^2.7.1",
-        "zendframework/zend-mvc": "^2.7 || ^3.0",
+        "zendframework/zend-mvc": "^2.7.14 || ^3.0",
         "zendframework/zend-navigation": "^2.5",
         "zendframework/zend-paginator": "^2.5",
         "zendframework/zend-permissions-acl": "^2.6",
@@ -51,6 +51,7 @@
         "zendframework/zend-http": "Zend\\Http component",
         "zendframework/zend-i18n": "Zend\\I18n component",
         "zendframework/zend-mvc": "Zend\\Mvc component",
+        "zendframework/zend-mvc-plugin-flashmessenger": "zend-mvc-plugin-flashmessenger component, if you want to use the FlashMessenger view helper with zend-mvc versions 3 and up",
         "zendframework/zend-navigation": "Zend\\Navigation component",
         "zendframework/zend-paginator": "Zend\\Paginator component",
         "zendframework/zend-permissions-acl": "Zend\\Permissions\\Acl component",